From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754492Ab2A3Wo3 (ORCPT ); Mon, 30 Jan 2012 17:44:29 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:41805 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754213Ab2A3Wo0 (ORCPT ); Mon, 30 Jan 2012 17:44:26 -0500 Date: Mon, 30 Jan 2012 22:43:50 +0000 From: Al Viro To: Greg KH Cc: Alan Cox , "Eric W. Biederman" , Jiri Slaby , LKML , systemd-devel@lists.freedesktop.org Subject: Re: sysfs regression: wrong link counts Message-ID: <20120130224350.GN23916@ZenIV.linux.org.uk> References: <4F27120A.4040106@suse.cz> <20120130220611.GA26655@kroah.com> <20120130221059.26ab5edf@pyramind.ukuu.org.uk> <20120130222717.GA6393@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120130222717.GA6393@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 30, 2012 at 02:27:17PM -0800, Greg KH wrote: > On Mon, Jan 30, 2012 at 10:10:59PM +0000, Alan Cox wrote: > > > Isn't there some other "proper" way of doing this in userspace, or is > > > this really the correct way? > > > > You can look at the S_IFMT bits and stuff however link count indicating > > number of subdirectories is a standard Unix thing and used by many quite > > mundane tools as an optimisation. > > Ah, yeah, that is easier. > > Eric, care to fix this or want me to revert it? Fix _what_? Userland shite quoted upthread? Because that's where the bug is - the mundane tools mentioned by Alan treat 1 in st_nlink as "no information about the number of subdirectories". And shite might be too mild a term for the little gem in question, really...