linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
	alan@linux.intel.com, jirislaby@gmail.com
Subject: Re: [PATCH 3/5] TTY: use tty_standard_install
Date: Thu, 2 Feb 2012 15:05:18 -0800	[thread overview]
Message-ID: <20120202230518.GA18903@kroah.com> (raw)
In-Reply-To: <1327954472-26594-3-git-send-email-jslaby@suse.cz>

On Mon, Jan 30, 2012 at 09:14:30PM +0100, Jiri Slaby wrote:
> Use the helper in the rest of the tty drivers. This is a simple
> replacement.

It would be, if you actually built this patch, as it is, it breaks :(

> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Acked-by: Alan Cox <alan@linux.intel.com>
> ---
>  drivers/isdn/capi/capi.c     |    9 +++------
>  drivers/misc/pti.c           |    6 +-----
>  drivers/mmc/card/sdio_uart.c |    9 +++------
>  drivers/tty/nozomi.c         |    8 ++------
>  4 files changed, 9 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c
> index e44933d..ca9261a 100644
> --- a/drivers/isdn/capi/capi.c
> +++ b/drivers/isdn/capi/capi.c
> @@ -1015,14 +1015,11 @@ capinc_tty_install(struct tty_driver *driver, struct tty_struct *tty)
>  {
>  	int idx = tty->index;
>  	struct capiminor *mp = capiminor_get(idx);
> -	int ret = tty_init_termios(tty);
> +	int ret = tty_standard_install(tty);

This, and, all of the other calls in this patch, should be (driver, tty)
for the function arguments, right?

That seems to fix the build for me, so I've checked it in, but please
verify that I got it right.

greg k-h

  parent reply	other threads:[~2012-02-02 23:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 20:14 [PATCH 1/5] TTY: provide tty_standard_install helper Jiri Slaby
2012-01-30 20:14 ` [PATCH 2/5] USB: serial, use tty_standard_install Jiri Slaby
2012-01-30 20:14 ` [PATCH 3/5] TTY: " Jiri Slaby
2012-01-30 20:37   ` Alan Cox
2012-02-01  9:40   ` Jiri Slaby
2012-02-01  9:52     ` Jiri Slaby
2012-02-02 23:05   ` Greg KH [this message]
2012-02-02 23:23     ` Jiri Slaby
2012-02-02 23:49       ` Greg KH
2012-01-30 20:14 ` [PATCH 4/5] TTY: pty, remove superfluous ptm test Jiri Slaby
2012-01-30 20:37   ` Alan Cox
2012-01-30 20:14 ` [PATCH 5/5] TTY: get rid of BTM around devpts_* Jiri Slaby
2012-01-30 20:36 ` [PATCH 1/5] TTY: provide tty_standard_install helper Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120202230518.GA18903@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=jirislaby@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).