From: Luis Henriques <luis.henriques@canonical.com>
To: Jarod Wilson <jarod@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] [media] ite-cir: postpone ISR registration
Date: Thu, 19 Apr 2012 22:32:26 +0100 [thread overview]
Message-ID: <20120419213226.GC22948@zeus> (raw)
In-Reply-To: <20120419204444.GB5165@redhat.com>
On Thu, Apr 19, 2012 at 04:44:44PM -0400, Jarod Wilson wrote:
> On Wed, Apr 18, 2012 at 09:54:07PM +0100, Luis Henriques wrote:
> > An early registration of an ISR was causing a crash to several users (for
> > example here: http://bugs.launchpad.net/bugs/972723 The reason was that
> > IRQs were being triggered before the driver initialisation was completed.
> >
> > This patch fixes this by moving the invocation to request_irq() to a later
> > stage on the driver probe function.
>
> Ugh. Looks like we actually have a similar problem with multiple lpc super
> i/o based CIR drivers. I'd probably move both the irq and io region
> requests in ite-cir, fintek-cir, nuvoton-cir, ene_ir and winbond-cir. If
> I'm thinking clearly, I've actually seen a very similar report for one of
> the other CIR drivers recently. Good catch. But yeah, lets do the same for
> all the drivers, and move request_region as well.
Yeah, I've realised the other drivers had the same issue. ite-cir was
just for one that bit us first.
Anyway, I'll be sending in a minute another patch with your comments.
Cheers,
--
Luis
prev parent reply other threads:[~2012-04-19 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 20:54 [PATCH 1/1] [media] ite-cir: postpone ISR registration Luis Henriques
2012-04-19 15:08 ` Luis Henriques
2012-04-19 20:44 ` Jarod Wilson
2012-04-19 21:32 ` Luis Henriques [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419213226.GC22948@zeus \
--to=luis.henriques@canonical.com \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).