From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
hpa@zytor.com, eranian@google.com, linux-kernel@vger.kernel.org,
fweisbec@gmail.com, akpm@linux-foundation.org,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org,
Robert Richter <robert.richter@amd.com>
Subject: Re: [tip:perf/core] perf/x86: Fix USER/KERNEL tagging of samples
Date: Tue, 10 Jul 2012 11:55:35 +0200 [thread overview]
Message-ID: <20120710095535.GC14821@gmail.com> (raw)
In-Reply-To: <1341913846.3462.105.camel@twins>
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, 2012-07-10 at 11:02 +0200, Peter Zijlstra wrote:
> > Ingo, do you want me to do a version where I simply bail on everything
> > if regs->{cs,ss} != {__USER_CS, __USER32_CS} || regs->flags & VM ?
>
> Here's a variant that does that..
> arch/x86/include/asm/perf_event.h | 11 +++++--
> arch/x86/kernel/cpu/perf_event.c | 46 +++++++++++++++++++++++++-----
> arch/x86/kernel/cpu/perf_event.h | 20 +++++++++++++
> arch/x86/kernel/cpu/perf_event_amd_ibs.c | 4 +-
> arch/x86/kernel/cpu/perf_event_intel_ds.c | 7 ++--
> 5 files changed, 74 insertions(+), 14 deletions(-)
this is the full thing:
> arch/x86/include/asm/perf_event.h | 11 ++-
> arch/x86/kernel/cpu/perf_event.c | 89 ++++++++++++++++++++++++++----
> arch/x86/kernel/cpu/perf_event.h | 20 ++++++
> arch/x86/kernel/cpu/perf_event_amd_ibs.c | 4 +
> arch/x86/kernel/cpu/perf_event_intel_ds.c | 7 +-
> 5 files changed, 114 insertions(+), 17 deletions(-)
so that's 40 LOC difference.
Hm, I expected there to be more of a difference, so let me
change my mind again in view of the evidence: now I tend to
lean Linus's way, we might as well apply those extra 40 lines
now that you've written them :-)
Even if it is not enough to do proper segmented profiling,
should anyone be interested in such a profiling mode they'll
have a much easier job making it work, the rest looks mostly a
user space side job. Your larger patch looks safe enough at the
boundaries.
Thanks,
Ingo
next prev parent reply other threads:[~2012-07-10 9:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 6:20 [tip:perf/core] perf/x86: Fix USER/KERNEL tagging of samples tip-bot for Peter Zijlstra
2012-07-06 16:29 ` Linus Torvalds
2012-07-06 18:12 ` Peter Zijlstra
2012-07-06 18:16 ` Linus Torvalds
2012-07-06 18:34 ` Linus Torvalds
2012-07-06 20:48 ` Peter Zijlstra
2012-07-06 20:59 ` Linus Torvalds
2012-07-09 11:23 ` Peter Zijlstra
2012-07-09 17:55 ` Linus Torvalds
2012-07-10 9:02 ` Peter Zijlstra
2012-07-10 9:48 ` Ingo Molnar
2012-07-10 9:50 ` Peter Zijlstra
2012-07-10 9:52 ` Peter Zijlstra
2012-07-10 9:55 ` Ingo Molnar [this message]
2012-07-31 17:57 ` [tip:perf/urgent] perf/x86: Fix USER/ KERNEL tagging of samples properly tip-bot for Peter Zijlstra
2012-07-09 18:41 ` [tip:perf/core] perf/x86: Fix USER/KERNEL tagging of samples Ingo Molnar
2012-07-10 7:54 ` Peter Zijlstra
2012-07-10 8:02 ` Ingo Molnar
2012-07-10 8:21 ` Ingo Molnar
2012-07-10 8:52 ` Peter Zijlstra
2012-07-10 9:48 ` Ingo Molnar
2012-07-31 18:11 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710095535.GC14821@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).