From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: "Bjørn Mork" <bjorn@mork.no>,
linux-input@vger.kernel.org, chunkeey@googlemail.com,
linville@tuxdriver.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: input0: bad kobj_uevent_env content in show_uevent()
Date: Sun, 2 Sep 2012 17:22:41 -0700 [thread overview]
Message-ID: <20120903002241.GA20054@kroah.com> (raw)
In-Reply-To: <20120902163831.GA26191@localhost>
On Mon, Sep 03, 2012 at 12:38:31AM +0800, Fengguang Wu wrote:
> On Sun, Sep 02, 2012 at 03:41:34PM +0200, Bjørn Mork wrote:
> > Fengguang Wu <fengguang.wu@intel.com> writes:
> >
> > > After the __devinit* removal series, I can still get kernel panic in
> > > show_uevent(). So there are more sources of bug..
> > >
> > > Debug patch:
> > >
> > > @@ -343,8 +343,11 @@ static ssize_t show_uevent(struct device
> > > goto out;
> > >
> > > /* copy keys to file */
> > > - for (i = 0; i < env->envp_idx; i++)
> > > + dev_err(dev, "uevent %d env[%d]: %s/.../%s\n", env->buflen, env->envp_idx, top_kobj->name, dev->kobj.name);
> > > + for (i = 0; i < env->envp_idx; i++) {
> > > + printk(KERN_ERR "uevent %d env[%d]: %s\n", (int)count, i, env->envp[i]);
> > > count += sprintf(&buf[count], "%s\n", env->envp[i]);
> > > + }
> > >
> > > Oops message, the env[] is again not properly initilized:
> > >
> > > [ 44.068623] input input0: uevent 61 env[805306368]: input0/.../input0
> > > [ 44.069552] uevent 0 env[0]: (null)
> >
> > This is a completely different CONFIG_HOTPLUG problem, only
> > demonstrating another reason why CONFIG_HOTPLUG should go away. I had a
> > hard time trying to disable it anyway ;-)
> >
> > The problem this time is lots of code assuming that a call to
> > add_uevent_var() will guarantee that env->buflen > 0. This is not true
> > if CONFIG_HOTPLUG is unset. So things like this end up overwriting
> > env->envp_idx because the array index is -1:
> >
> > if (add_uevent_var(env, "MODALIAS="))
> > return -ENOMEM;
> > len = input_print_modalias(&env->buf[env->buflen - 1],
> > sizeof(env->buf) - env->buflen,
> > dev, 0);
> >
> >
> > Don't know what the best action is, given that there seem to be a *lot*
> > of this around the kernel. This patch "fixes" the problem for me, but I
>
> It also works reliably for me: 300 boots without a single failure.
>
> Tested-by: Fengguang Wu <fengguang.wu@intel.com>
Thanks for figuring this out. I'll apply it for 3.6, but work to get
rid of CONFIG_HOTPLUG completly for 3.7 as it just causes problems.
greg k-h
next prev parent reply other threads:[~2012-09-03 0:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 7:59 input0: bad kobj_uevent_env content in show_uevent() Fengguang Wu
2012-09-02 8:34 ` Fengguang Wu
2012-09-02 8:37 ` Fengguang Wu
2012-09-04 11:46 ` Jean Delvare
2012-09-04 11:54 ` Fengguang Wu
2012-09-04 11:56 ` Bjørn Mork
2012-09-02 13:41 ` Bjørn Mork
2012-09-02 16:38 ` Fengguang Wu
2012-09-03 0:22 ` Greg Kroah-Hartman [this message]
2012-09-03 7:01 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120903002241.GA20054@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bjorn@mork.no \
--cc=chunkeey@googlemail.com \
--cc=fengguang.wu@intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).