From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, linux-efi@vger.kernel.org
Subject: Re: [PATCH 05/11] asus-wmi: Restrict debugfs interface
Date: Tue, 4 Sep 2012 17:12:05 +0100 [thread overview]
Message-ID: <20120904171205.3dfbcabd@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1346774117-2277-6-git-send-email-mjg@redhat.com>
On Tue, 4 Sep 2012 11:55:11 -0400
Matthew Garrett <mjg@redhat.com> wrote:
> We have no way of validating what all of the Asus WMI methods do on a
> given machine, and there's a risk that some will allow hardware state to
> be manipulated in such a way that arbitrary code can be executed in the
> kernel. Add a capability check to prevent that.
This is true of any firmware method on any device Why pick on ASUS. Have
you run this through ASUS and discussed it with them. It seems highly
inappropriate to cripple a specific vendors feature set without
discussion and an Ack from the vendor concerned.
Alan
next prev parent reply other threads:[~2012-09-04 16:07 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 15:55 [RFC] First attempt at kernel secure boot support Matthew Garrett
2012-09-04 15:55 ` [PATCH 01/11] Secure boot: Add new capability Matthew Garrett
2012-09-04 15:55 ` [PATCH 02/11] PCI: Lock down BAR access in secure boot environments Matthew Garrett
2012-10-01 21:00 ` Pavel Machek
2012-09-04 15:55 ` [PATCH 03/11] x86: Lock down IO port " Matthew Garrett
2012-09-04 16:16 ` Alan Cox
2012-09-04 16:16 ` Matthew Garrett
2012-09-04 15:55 ` [PATCH 04/11] ACPI: Limit access to custom_method Matthew Garrett
2012-09-04 15:55 ` [PATCH 05/11] asus-wmi: Restrict debugfs interface Matthew Garrett
2012-09-04 16:12 ` Alan Cox [this message]
2012-09-04 16:13 ` Matthew Garrett
2012-09-04 15:55 ` [PATCH 06/11] Restrict /dev/mem and /dev/kmem in secure boot setups Matthew Garrett
2012-09-04 15:55 ` [PATCH 07/11] kexec: Disable in a secure boot environment Matthew Garrett
2012-09-04 20:13 ` Eric W. Biederman
2012-09-04 20:22 ` Matthew Garrett
2012-09-04 21:13 ` Eric W. Biederman
2012-09-04 21:27 ` Matthew Garrett
2012-09-04 22:12 ` Eric W. Biederman
2012-09-04 23:25 ` Matthew Garrett
2012-09-05 4:33 ` Eric W. Biederman
2012-09-05 5:16 ` Matthew Garrett
2012-09-05 7:00 ` Eric W. Biederman
2012-09-05 7:03 ` Matthew Garrett
2012-09-04 21:39 ` Alan Cox
2012-09-04 21:40 ` Matthew Garrett
2012-09-05 15:43 ` Roland Eggner
2012-09-05 15:46 ` Matthew Garrett
2012-09-05 21:13 ` Mimi Zohar
2012-09-05 21:41 ` Matthew Garrett
2012-09-05 21:49 ` Eric Paris
2012-09-04 15:55 ` [PATCH 08/11] Secure boot: Add a dummy kernel parameter that will switch on Secure Boot mode Matthew Garrett
2012-09-04 15:55 ` [PATCH 09/11] efi: Enable secure boot lockdown automatically when enabled in firmware Matthew Garrett
2012-09-04 15:55 ` [PATCH 10/11] acpi: Ignore acpi_rsdp kernel parameter in a secure boot environment Matthew Garrett
2012-09-04 16:30 ` Shuah Khan
2012-09-04 16:38 ` Matthew Garrett
2012-09-04 16:44 ` Shuah Khan
2012-09-04 20:37 ` Alan Cox
2012-09-04 20:37 ` Matthew Garrett
2012-09-04 20:50 ` Josh Boyer
2012-09-04 15:55 ` [PATCH 11/11] SELinux: define mapping for new Secure Boot capability Matthew Garrett
2012-09-04 16:08 ` [RFC] First attempt at kernel secure boot support Alan Cox
2012-09-04 16:12 ` Matthew Garrett
2012-10-01 21:07 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904171205.3dfbcabd@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).