linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nicolas.ferre@atmel.com
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	havard@skinnemoen.net, plagnioj@jcrosoft.com,
	jamie@jamieiles.com, linux-kernel@vger.kernel.org,
	patrice.vilchez@atmel.com
Subject: Re: [PATCH 09/10] net/macb: ethtool interface: add register dump feature
Date: Wed, 05 Sep 2012 17:32:08 -0400 (EDT)	[thread overview]
Message-ID: <20120905.173208.1472160105562166368.davem@davemloft.net> (raw)
In-Reply-To: <fcd1c2443a30f23ffcd8de28328c5a382e2a2459.1346775479.git.nicolas.ferre@atmel.com>

From: Nicolas Ferre <nicolas.ferre@atmel.com>
Date: Wed, 5 Sep 2012 11:00:54 +0200

> @@ -10,6 +10,9 @@
>  #ifndef _MACB_H
>  #define _MACB_H
>  
> +
> +#define MACB_GREGS_LEN 32

Please don't add such extraneous empty lines.  One empty line between
constructs is more than enough, and anything more is visually awkward.

Thanks.



  reply	other threads:[~2012-09-05 21:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05  8:19 [PATCH 00/10] net/macb: driver enhancement concerning GEM support, ring logic and cleanup Nicolas Ferre
2012-09-05  8:19 ` [PATCH 01/10] net/macb: Add support for Gigabit Ethernet mode Nicolas Ferre
2012-09-05  8:19 ` [PATCH 02/10] net/macb: memory barriers cleanup Nicolas Ferre
2012-09-05  8:19 ` [PATCH 03/10] net/macb: change debugging messages Nicolas Ferre
2012-09-05  8:19 ` [PATCH 04/10] net/macb: Fix a race in macb_start_xmit() Nicolas Ferre
2012-09-05 21:30   ` David Miller
2012-09-06 14:52     ` Nicolas Ferre
2012-09-06 15:49     ` Havard Skinnemoen
2012-09-07 16:34       ` Nicolas Ferre
2012-09-05  9:00 ` [PATCH 05/10] net/macb: clean up ring buffer logic Nicolas Ferre
2012-09-05  9:00 ` [PATCH 06/10] net/macb: better manage tx errors Nicolas Ferre
2012-09-05  9:00 ` [PATCH 07/10] net/macb: tx status is more than 8 bits now Nicolas Ferre
2012-09-05  9:00 ` [PATCH 08/10] net/macb: macb_get_drvinfo: add GEM/MACB suffix to differentiate revision Nicolas Ferre
2012-09-05 21:31   ` David Miller
2012-09-05 23:27   ` Ben Hutchings
2012-09-06 14:01     ` Nicolas Ferre
2012-09-06 17:42       ` David Miller
2012-09-05  9:00 ` [PATCH 09/10] net/macb: ethtool interface: add register dump feature Nicolas Ferre
2012-09-05 21:32   ` David Miller [this message]
2012-09-05 23:36   ` Ben Hutchings
2012-09-06 14:20     ` [PATCH v2 " Nicolas Ferre
2012-09-06 14:34       ` Ben Hutchings
2012-09-05  9:04 ` [PATCH 10/10] net/macb: Offset first RX buffer by two bytes Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120905.173208.1472160105562166368.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=havard@skinnemoen.net \
    --cc=jamie@jamieiles.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=patrice.vilchez@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).