From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anton Arapov <anton@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] uprobes: uprobes_treelock should not disable irqs
Date: Fri, 14 Sep 2012 21:48:48 +0530 [thread overview]
Message-ID: <20120914161848.GC28033@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120819164037.GA25480@redhat.com>
* Oleg Nesterov <oleg@redhat.com> [2012-08-19 18:40:37]:
> Nobody plays with uprobes_tree/uprobes_treelock in interrupt context,
> no need to disable irqs.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
> kernel/events/uprobes.c | 21 ++++++++-------------
> 1 files changed, 8 insertions(+), 13 deletions(-)
>
> diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
> index 25c0d74..abe077e 100644
> --- a/kernel/events/uprobes.c
> +++ b/kernel/events/uprobes.c
> @@ -413,11 +413,10 @@ static struct uprobe *__find_uprobe(struct inode *inode, loff_t offset)
> static struct uprobe *find_uprobe(struct inode *inode, loff_t offset)
> {
> struct uprobe *uprobe;
> - unsigned long flags;
>
> - spin_lock_irqsave(&uprobes_treelock, flags);
> + spin_lock(&uprobes_treelock);
> uprobe = __find_uprobe(inode, offset);
> - spin_unlock_irqrestore(&uprobes_treelock, flags);
> + spin_unlock(&uprobes_treelock);
>
> return uprobe;
> }
> @@ -464,12 +463,11 @@ static struct uprobe *__insert_uprobe(struct uprobe *uprobe)
> */
> static struct uprobe *insert_uprobe(struct uprobe *uprobe)
> {
> - unsigned long flags;
> struct uprobe *u;
>
> - spin_lock_irqsave(&uprobes_treelock, flags);
> + spin_lock(&uprobes_treelock);
> u = __insert_uprobe(uprobe);
> - spin_unlock_irqrestore(&uprobes_treelock, flags);
> + spin_unlock(&uprobes_treelock);
>
> /* For now assume that the instruction need not be single-stepped */
> uprobe->flags |= UPROBE_SKIP_SSTEP;
> @@ -707,11 +705,9 @@ remove_breakpoint(struct uprobe *uprobe, struct mm_struct *mm, unsigned long vad
> */
> static void delete_uprobe(struct uprobe *uprobe)
> {
> - unsigned long flags;
> -
> - spin_lock_irqsave(&uprobes_treelock, flags);
> + spin_lock(&uprobes_treelock);
> rb_erase(&uprobe->rb_node, &uprobes_tree);
> - spin_unlock_irqrestore(&uprobes_treelock, flags);
> + spin_unlock(&uprobes_treelock);
> iput(uprobe->inode);
> put_uprobe(uprobe);
> atomic_dec(&uprobe_events);
> @@ -969,7 +965,6 @@ static void build_probe_list(struct inode *inode,
> struct list_head *head)
> {
> loff_t min, max;
> - unsigned long flags;
> struct rb_node *n, *t;
> struct uprobe *u;
>
> @@ -977,7 +972,7 @@ static void build_probe_list(struct inode *inode,
> min = vaddr_to_offset(vma, start);
> max = min + (end - start) - 1;
>
> - spin_lock_irqsave(&uprobes_treelock, flags);
> + spin_lock(&uprobes_treelock);
> n = find_node_in_range(inode, min, max);
> if (n) {
> for (t = n; t; t = rb_prev(t)) {
> @@ -995,7 +990,7 @@ static void build_probe_list(struct inode *inode,
> atomic_inc(&u->ref);
> }
> }
> - spin_unlock_irqrestore(&uprobes_treelock, flags);
> + spin_unlock(&uprobes_treelock);
> }
>
> /*
> --
> 1.5.5.1
>
next prev parent reply other threads:[~2012-09-14 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 16:40 [PATCH 0/3] uprobes: teach uprobes to clear MMF_HAS_UPROBES Oleg Nesterov
2012-08-19 16:40 ` [PATCH 1/3] uprobes: uprobes_treelock should not disable irqs Oleg Nesterov
2012-09-14 16:18 ` Srikar Dronamraju [this message]
2012-08-19 16:40 ` [PATCH 2/3] uprobes: introduce MMF_RECALC_UPROBES Oleg Nesterov
2012-09-14 16:32 ` Srikar Dronamraju
2012-08-19 16:40 ` [PATCH 3/3] uprobes: teach find_active_uprobe() to clear MMF_HAS_UPROBES Oleg Nesterov
2012-09-14 16:43 ` Srikar Dronamraju
2012-09-15 14:41 ` Oleg Nesterov
2012-08-27 17:44 ` [PATCH 0/3] uprobes: teach uprobes " Oleg Nesterov
2012-08-29 17:54 ` [GIT PULL] (Was: uprobes: teach uprobes to clear MMF_HAS_UPROBES) Oleg Nesterov
2012-08-30 8:18 ` Ingo Molnar
2012-09-14 17:12 ` [PATCH 0/3] uprobes: teach uprobes to clear MMF_HAS_UPROBES Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914161848.GC28033@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).