linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Anmol Sarma <unmole.in@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	arve@android.com
Subject: Re: [PATCH] Staging: android: binder: Fixed multi-line strings
Date: Mon, 22 Oct 2012 13:02:12 -0700	[thread overview]
Message-ID: <20121022200212.GA18168@kroah.com> (raw)
In-Reply-To: <1349738114.15802.27.camel@joe-AO722>

On Mon, Oct 08, 2012 at 04:15:14PM -0700, Joe Perches wrote:
> On Tue, 2012-10-09 at 00:31 +0530, Anmol Sarma wrote:
> > Changed all user visible multi-line stings to single line.
> 
> Another patch might be to add
> 
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
> before any #include and
> 
> > diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> []
> > @@ -556,8 +556,8 @@ static int binder_update_page_range(struct binder_proc *proc, int allocate,
> >  		goto free_range;
> >  
> >  	if (vma == NULL) {
> > -		pr_err("binder: %d: binder_alloc_buf failed to "
> > -		       "map pages in userspace, no vma\n", proc->pid);
> > +		pr_err("binder: %d: binder_alloc_buf failed to map pages in userspace, no vma\n",
> > +			proc->pid);
> 
> remove all the "binder: " prefixes like:
> 
> 		pr_err("%d: binder_alloc_buf failed to map pages in userspace, no vma\n",
> 		       proc->pid);

Yes, that would be the better fix.

Anmol, care to redo this patch that way?

thanks,

greg k-h

  reply	other threads:[~2012-10-22 20:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-08 19:01 [PATCH] Staging: android: binder: Fixed multi-line strings Anmol Sarma
2012-10-08 23:15 ` Joe Perches
2012-10-22 20:02   ` Greg KH [this message]
2012-10-23  9:43     ` Anmol Sarma
2012-10-24  4:13       ` Greg KH
2012-10-24  7:58         ` Anmol Sarma
2012-10-24 22:29           ` Greg KH
2012-10-25  8:06             ` Anmol Sarma
2012-10-25 19:25               ` Greg KH
2012-10-26  7:26                 ` Anmol Sarma
2012-10-26  8:24                 ` Anmol Sarma
2012-10-29 21:53                   ` Greg KH
2012-10-30 17:05                     ` Anmol Sarma
2012-10-09  8:29 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121022200212.GA18168@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=unmole.in@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).