From: Francois Romieu <romieu@fr.zoreil.com>
To: hayeswang <hayeswang@realtek.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] r8169: enable ALDPS for power saving
Date: Wed, 24 Oct 2012 22:05:25 +0200 [thread overview]
Message-ID: <20121024200525.GB6347@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <B3B61E0990514F28A8203537EB9D047A@realtek.com.tw>
hayeswang <hayeswang@realtek.com> :
> Francois Romieu [mailto:romieu@fr.zoreil.com]
> [...]
> > It would be nice to state these things in the commit message, namely:
> > - ALDPS should never be enabled for the RTL8105e
> > - none of the firmware-free chipsets support ALDPS
> > - neither do the RTL8168d/8111d
>
> Excuse me. I don't understand why the RTL8105e shouldn't enable ALDPS.
I'd appreciate to see such a statement if ALDPS can be enabled with the
RTL8105e !
You have sent ALDPS related patches for some specific chipsets. Now
would be a sensible time to check if ALDPS is correctly handled for
_all_ supported chipsets. I don't have access to your authoritative
resources. I can only outline something strange in the code wrt
ALDPS and the 8105e.
/me returns to 8169b RxOverflow oddities...
--
Ueimor
next prev parent reply other threads:[~2012-10-24 20:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 8:05 [PATCH net-next 1/2] r8169: enable ALDPS for power saving Hayes Wang
2012-10-22 17:59 ` David Miller
2012-10-22 19:27 ` Francois Romieu
2012-10-23 2:24 ` hayeswang
2012-10-23 19:31 ` Francois Romieu
2012-10-24 5:55 ` hayeswang
2012-10-24 20:05 ` Francois Romieu [this message]
2012-10-23 6:47 ` [PATCH v2 " Hayes Wang
2012-10-23 6:47 ` [PATCH v2 net-next 2/2] r8169: update the settings for RTL8111G Hayes Wang
2012-10-23 19:41 ` Francois Romieu
2012-10-23 19:33 ` [PATCH v2 net-next 1/2] r8169: enable ALDPS for power saving Francois Romieu
2012-10-24 5:55 ` hayeswang
2012-10-24 6:24 ` [PATCH v3 net-next] " Hayes Wang
2012-10-24 21:20 ` Francois Romieu
2012-10-26 6:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024200525.GB6347@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).