From: Greg KH <gregkh@linuxfoundation.org>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com
Subject: Re: [PATCH 3/3] Drivers: hv: Get rid of hv_ringbuffer_cleanup()
Date: Wed, 24 Oct 2012 15:45:28 -0700 [thread overview]
Message-ID: <20121024224528.GA30009@kroah.com> (raw)
In-Reply-To: <1350073363-10614-3-git-send-email-kys@microsoft.com>
On Fri, Oct 12, 2012 at 01:22:43PM -0700, K. Y. Srinivasan wrote:
> hv_ringbuffer_cleanup() is an empty function; get rid of it.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
> Reported-by: Jason Wang <jasowang@redhat.com>
> Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/hv/channel.c | 4 ----
> drivers/hv/hyperv_vmbus.h | 1 -
> drivers/hv/ring_buffer.c | 11 -----------
> 3 files changed, 0 insertions(+), 16 deletions(-)
That's nice, but this patch causes build failures, so I can't accept it.
Please test your patches better (hint, a simple 'git grep' would have
worked here...)
greg k-h
next prev parent reply other threads:[~2012-10-24 22:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 20:22 [PATCH 0/3] Drivers: hv: vmbus K. Y. Srinivasan
2012-10-12 20:22 ` [PATCH 1/3] Drivers: hv: Get rid of unnecessary forward declarations K. Y. Srinivasan
2012-10-12 20:22 ` [PATCH 2/3] Drivers: hv: Cleanup error handling in vmbus_open() K. Y. Srinivasan
2012-10-18 9:46 ` Dan Carpenter
2012-10-12 20:22 ` [PATCH 3/3] Drivers: hv: Get rid of hv_ringbuffer_cleanup() K. Y. Srinivasan
2012-10-24 22:45 ` Greg KH [this message]
2012-10-25 14:13 ` KY Srinivasan
2012-10-17 6:10 ` [PATCH 0/3] Drivers: hv: vmbus Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024224528.GA30009@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).