On Sat, Oct 27, 2012 at 01:39:00PM +0000, Michal Simek wrote: > Hi Josh, > > > -----Original Message----- > > From: Josh Cartwright [mailto:josh.cartwright@ni.com] > > Sent: Wednesday, October 24, 2012 10:03 PM > > To: arm@kernel.org; Arnd Bergmann > > Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; John > > Linn; Nick Bowler; Michal Simek > > Subject: [PATCH v4 1/5] zynq: use GIC device tree bindings > > > > The Zynq uses the cortex-a9-gic. This eliminates the need to hardcode register > > addresses. > > > > Signed-off-by: Josh Cartwright > > Cc: John Linn > > Acked-by: Arnd Bergmann > > --- > > arch/arm/boot/dts/zynq-ep107.dts | 8 +++++--- > > arch/arm/mach-zynq/common.c | 7 ++++++- > > arch/arm/mach-zynq/include/mach/zynq_soc.h | 2 -- > > 3 files changed, 11 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm/boot/dts/zynq-ep107.dts b/arch/arm/boot/dts/zynq- > > ep107.dts > > index 37ca192..7bfff4a 100644 > > --- a/arch/arm/boot/dts/zynq-ep107.dts > > +++ b/arch/arm/boot/dts/zynq-ep107.dts > > @@ -36,10 +36,12 @@ > > ranges; > > > > intc: interrupt-controller@f8f01000 { > > + compatible = "arm,cortex-a9-gic"; > > + #interrupt-cells = <3>; > > If you change git to 3 cells format you should also change it for uart below. > > Also will be the best to remove this dts entirely and replace it by existing > Platform. Do you mean to say get rid of the ep107 entirely and replace it with, for example, a zc702 dts? I have a follow up patchset which splits off a zynq-7000.dtsi and a zynq-zc702.dts, and which also fixes the 3 interrupt cell problem. Would you like for me to pull this into v5, or spin up a separate patch series? Thanks, Josh