From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965181Ab2KVT1j (ORCPT ); Thu, 22 Nov 2012 14:27:39 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:60736 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965125Ab2KVT1g (ORCPT ); Thu, 22 Nov 2012 14:27:36 -0500 Date: Thu, 22 Nov 2012 14:05:40 +0000 From: Lee Jones To: Ola Lilja Cc: "linus.walleij@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" , Linus WALLEIJ , "arnd@arndb.de" , "broonie@opensource.wolfsonmicro.com" , STEricsson_nomadik_linux Subject: Re: [RESENDING] [PATCH 07/22] ASoC: Ux500: Initialise PCM from MSP probe rather than as a device Message-ID: <20121122140540.GA10986@gmail.com> References: <1344527268-5964-1-git-send-email-lee.jones@linaro.org> <1344527268-5964-8-git-send-email-lee.jones@linaro.org> <20120919133343.GH25694@gmail.com> <505ADBE6.6080509@stericsson.com> <20120920125259.GA2755@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20120920125259.GA2755@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Sep 2012, Lee Jones wrote: > > > Can we have some closure on this patch please, as it's blocking the > > > patch-set? I'm fairly sure the patch is doing the correct thing, as > > > seconded by Mark. > > > > I still don't like this. It is the dai_link-struct that bothers me. We have > > "ux500-msp-i2s.1" as name of the platform AND the cpu_dai. The MSP I2S-block is > > not the platform and it is certainly not both platform and cpu-DAI at the same time. > > Mark: Did you have a solution for this? Couldn't we just put NULL on the > > platform_name instead? > > There are other drivers which do this already. > > I don't think it's an issue to do this. Has anyone had any more bright ideas on how we might handle this? The device is still being handled in platform code and I'm desperate to get it out of there. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog