linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Mike Travis <travis@sgi.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Dimitri Sivanich <sivanich@sgi.com>
Subject: Re: [PATCH 6/7] x86, UV: UV3 Check current gru hub support.
Date: Mon, 11 Feb 2013 10:40:32 +0100	[thread overview]
Message-ID: <20130211094032.GD23932@gmail.com> (raw)
In-Reply-To: <20130208184306.212373913@gulag1.americas.sgi.com>


* Mike Travis <travis@sgi.com> wrote:

> This patch checks current hub support to avoid panicing the
> system until all the GRU changes for UV3+ are in place.
> 
> Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
> Signed-off-by: Mike Travis <travis@sgi.com>

That's a weird signoff sequence. It should either also include a 
From: Dimitri tag at the front, or the Signed-off-by should be 
Acked-by.

Please also use consistent titles in your patches, standardizing 
on this pattern would be nice:

   x86/UV/UV3: Check current gru hub support

while UV patches affecting all UV models would come with a 
'x86/UV:' title or so.

Thanks,

	Ingo

  reply	other threads:[~2013-02-11  9:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-08 18:43 [PATCH 0/7] x86: SGI UV3 Kernel Updates Mike Travis
2013-02-08 18:43 ` [PATCH 1/7] x86, UV: UV3 Update MMR register definitions Mike Travis
2013-02-08 18:43 ` [PATCH 2/7] x86, UV: UV3 Update ACPI Check Mike Travis
2013-02-08 18:43 ` [PATCH 3/7] x86: UV3 Update Hub Info Mike Travis
2013-02-08 18:43 ` [PATCH 4/7] x86, UV: UV3 Update x2apic Support Mike Travis
2013-02-08 18:43 ` [PATCH 5/7] x86, UV: UV3 Update Time Support Mike Travis
2013-02-08 18:43 ` [PATCH 6/7] x86, UV: UV3 Check current gru hub support Mike Travis
2013-02-11  9:40   ` Ingo Molnar [this message]
2013-02-11 16:36     ` Mike Travis
2013-02-08 18:43 ` [PATCH 7/7] x86, UV: UV3 Trim MMR register definitions after code changes Mike Travis
  -- strict thread matches above, loose matches on Subject: below --
2013-02-05 22:26 [PATCH 0/7] x86: SGI UV3 Kernel Updates Mike Travis
2013-02-05 22:26 ` [PATCH 6/7] x86, UV: UV3 Check current gru hub support Mike Travis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130211094032.GD23932@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sivanich@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=travis@sgi.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).