From: Ingo Molnar <mingo@kernel.org>
To: Yinghai Lu <yinghai@kernel.org>, Greg KH <gregkh@suse.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@ftp.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>, "H. Peter Anvin" <hpa@zytor.com>,
Laura Abbott <lauraa@codeaurora.org>,
Mel Gorman <mgorman@suse.de>
Subject: [-rc7 regression] Buggy commit: "mm: use aligned zone start for pfn_to_bitidx calculation"
Date: Fri, 15 Feb 2013 12:44:26 +0100 [thread overview]
Message-ID: <20130215114425.GD26955@gmail.com> (raw)
In-Reply-To: <CAE9FiQXc=7+TMwbfd20YiHNfOHX_kUOzYcVm8-uaP2R_C_1RRg@mail.gmail.com>
[ Greg: -stable was Cc:-ed for this potentially buggy commit. ]
* Yinghai Lu <yinghai@kernel.org> wrote:
> On Thu, Feb 14, 2013 at 7:08 AM, Ingo Molnar <mingo@kernel.org> wrote:
> > these three:
> >
> > 10d73e655cef mm: bootmem: fix free_all_bootmem_core() with odd bitmap alignment
> > c060f943d092 mm: use aligned zone start for pfn_to_bitidx calculation
> > c0232ae861df mm: memblock: fix wrong memmove size in memblock_merge_regions()
> >
> > might have highmem=512m boot parameter sensitivity.
>
> 10d73e655cef should not be related, as we are using nobootmem wrapper
> of memblock.
> c0232ae861df is copying less while using the blank slot in memblock
> memory or reserved array
> so it should be ok too.
>
> c060f943d092 may be related as you config does not have
> CONFIG_SPARSEMEM defined.
Right, that's the commit causing the x86 regression:
c060f943d0929f3e429c5d9522290584f6281d6e is the first bad commit
commit c060f943d0929f3e429c5d9522290584f6281d6e
Date: Fri Jan 11 14:31:51 2013 -0800
mm: use aligned zone start for pfn_to_bitidx calculation
I've given 6d92d4f (its parent commit) quite a bit of testing so
I'm 99% sure in the validity of this bisection result.
Involved parties Cc:-ed.
Revert attached below - it reverts cleanly and I'll test this
today, to see whether this solves the sporadic lockups.
Thanks,
Ingo
------------------->
>From 6f3d5a8f38eb23f792b408d9bc8fee53a7d158f9 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@kernel.org>
Date: Fri, 15 Feb 2013 12:43:22 +0100
Subject: [PATCH] Revert "mm: use aligned zone start for pfn_to_bitidx
calculation"
This reverts commit c060f943d0929f3e429c5d9522290584f6281d6e.
Causes lockups.
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index cf46618..3a120bb 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5590,7 +5590,7 @@ static inline int pfn_to_bitidx(struct zone *zone, unsigned long pfn)
pfn &= (PAGES_PER_SECTION-1);
return (pfn >> pageblock_order) * NR_PAGEBLOCK_BITS;
#else
- pfn = pfn - round_down(zone->zone_start_pfn, pageblock_nr_pages);
+ pfn = pfn - zone->zone_start_pfn;
return (pfn >> pageblock_order) * NR_PAGEBLOCK_BITS;
#endif /* CONFIG_SPARSEMEM */
}
next prev parent reply other threads:[~2013-02-15 11:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 21:51 Linux v3.8-rc7 Linus Torvalds
2013-02-10 0:14 ` [REGRESSION] -rc7/-rc4+: unable to USB boot - enumeration partially broken (was: Linux v3.8-rc7) Andreas Mohr
2013-02-10 14:05 ` Andreas Mohr
2013-02-12 16:07 ` Andreas Mohr
2013-02-12 16:16 ` Greg KH
2013-02-12 21:25 ` Andreas Mohr
2013-02-13 6:44 ` [REGRESSION] [nailed] USB boot failure: USB: EHCI: make ehci-pci a separate driver Andreas Mohr
2013-02-13 7:16 ` Andreas Mohr
2013-02-13 7:44 ` Andreas Mohr
2013-02-13 10:05 ` Andreas Mohr
2013-02-13 10:50 ` Colin Guthrie
2013-02-13 16:13 ` Andreas Mohr
2013-02-13 16:26 ` Colin Guthrie
2013-02-13 11:10 ` [-rc7 regression] Block IO/VFS/ext3/timer spinlock lockup? Ingo Molnar
2013-02-13 16:59 ` Linus Torvalds
2013-02-13 23:20 ` Thomas Gleixner
2013-02-14 14:45 ` Ingo Molnar
2013-02-14 14:54 ` Ingo Molnar
2013-02-14 15:08 ` Ingo Molnar
2013-02-14 17:28 ` Thomas Gleixner
2013-02-14 18:22 ` Yinghai Lu
2013-02-15 11:44 ` Ingo Molnar [this message]
2013-02-15 22:06 ` [-rc7 regression] Buggy commit: "mm: use aligned zone start for pfn_to_bitidx calculation" Greg KH
2013-02-16 8:29 ` Ingo Molnar
2013-03-01 16:50 ` Greg KH
2013-03-01 17:07 ` Linus Torvalds
2013-03-01 17:14 ` Greg KH
2013-02-16 8:25 ` Ingo Molnar
2013-02-16 18:26 ` Linus Torvalds
2013-02-16 19:38 ` Yinghai Lu
2013-02-16 19:51 ` Linus Torvalds
2013-02-18 8:49 ` Ingo Molnar
2013-02-18 14:46 ` Mel Gorman
2013-02-18 18:42 ` Laura Abbott
2013-02-14 23:05 ` [-rc7 regression] Block IO/VFS/ext3/timer spinlock lockup? Linus Torvalds
2013-02-15 11:39 ` [PATCH] spinlock/debugging: Print out lock name when available Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130215114425.GD26955@gmail.com \
--to=mingo@kernel.org \
--cc=axboe@kernel.dk \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=lauraa@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=viro@ftp.linux.org.uk \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).