From: Daniel Vetter <daniel@ffwll.ch>
To: Borislav Petkov <bp@alien8.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Dave Airlie <airlied@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] drm: don't check modeset locks in panic handler
Date: Thu, 2 May 2013 22:45:11 +0200 [thread overview]
Message-ID: <20130502204511.GH5763@phenom.ffwll.local> (raw)
In-Reply-To: <20130502101308.GA16684@pd.tnic>
On Thu, May 02, 2013 at 12:13:08PM +0200, Borislav Petkov wrote:
> On Thu, May 02, 2013 at 09:43:05AM +0200, Daniel Vetter wrote:
> > Since we know that locking is broken in that case and it's more
> > important to not flood the dmesg with random gunk.
> >
> > Cc: Dave Airlie <airlied@gmail.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > References: https://groups.google.com/forum/?fromgroups=#!topic/linux.kernel/QFzFxSUeV4I
>
> Yeah, we have this nice redirector service on k.org which uses the
> Message-ID only and doesn't rely on some external URLs remaining stable.
> You could use that instead:
>
> Link: http://lkml.kernel.org/r/20130502000206.GH15623@pd.tnic
>
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> > drivers/gpu/drm/drm_crtc.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> > index 792c3e3..3be0802 100644
> > --- a/drivers/gpu/drm/drm_crtc.c
> > +++ b/drivers/gpu/drm/drm_crtc.c
> > @@ -78,6 +78,10 @@ void drm_warn_on_modeset_not_all_locked(struct drm_device *dev)
> > {
> > struct drm_crtc *crtc;
> >
> > + /* Locking is currently fubar in the panic handler. */
> > + if (oops_in_progress)
> > + return;
> > +
> > list_for_each_entry(crtc, &dev->mode_config.crtc_list, head)
> > WARN_ON(!mutex_is_locked(&crtc->mutex));
>
> Yep, thanks.
>
> Reported-and-tested-by: Borislav Petkov <bp@suse.de>
Thanks for testing, patch applied to drm-intel-fixes.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-05-02 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 0:02 WARNING: at drivers/gpu/drm/drm_crtc.c:82 drm_warn_on_modeset_not_all_locked+0x8d/0xc0() Borislav Petkov
2013-05-02 0:41 ` Daniel Vetter
2013-05-02 0:57 ` Dave Airlie
2013-05-02 7:43 ` [PATCH] drm: don't check modeset locks in panic handler Daniel Vetter
2013-05-02 10:13 ` Borislav Petkov
2013-05-02 20:45 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502204511.GH5763@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=bp@alien8.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).