From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
peterz@infradead.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 4/6] Move might_sleep and friends from kernel.h to sched.h
Date: Tue, 27 Aug 2013 16:50:11 -0700 [thread overview]
Message-ID: <20130827165011.b46c71b618e5cdc444af2804@linux-foundation.org> (raw)
In-Reply-To: <1376687844-19857-5-git-send-email-andi@firstfloor.org>
On Fri, 16 Aug 2013 14:17:22 -0700 Andi Kleen <andi@firstfloor.org> wrote:
> These are really related to scheduling, so they should be in sched.h
> Users usually will need to schedule anyways.
>
> The advantage of having them there is that we can access some of the
> scheduler inlines to make their fast path more efficient. This will come
> in a followon patch.
alpha allmodconfig:
mm/memory.c:4236: error: redefinition of 'might_fault'
include/linux/sched.h:2485: note: previous definition of 'might_fault' was here
Presumably because CONFIG_PROVE_LOCKING=n && CONFIG_DEBUG_ATOMIC_SLEEP=y.
That code is too tangly for me to fix it up with any confidence, sorry.
next prev parent reply other threads:[~2013-08-27 23:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 21:17 Improve preempt-scheduling and x86 user access v3 Andi Kleen
2013-08-16 21:17 ` [PATCH 1/6] x86: Add 1/2/4/8 byte optimization to 64bit __copy_{from,to}_user_inatomic Andi Kleen
2013-09-10 23:30 ` [tip:x86/uaccess] x86: Add 1/2/4/ 8 " tip-bot for Andi Kleen
2013-08-16 21:17 ` [PATCH 2/6] x86: Include linux/sched.h in asm/uaccess.h Andi Kleen
2013-08-16 21:17 ` [PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users Andi Kleen
2013-08-31 18:22 ` Geert Uytterhoeven
2013-09-10 23:52 ` Andrew Morton
2013-09-11 4:51 ` Andi Kleen
2013-09-11 5:36 ` Ingo Molnar
2013-08-16 21:17 ` [PATCH 4/6] Move might_sleep and friends from kernel.h to sched.h Andi Kleen
2013-08-27 23:50 ` Andrew Morton [this message]
2013-08-16 21:17 ` [PATCH 5/6] sched: mark should_resched() __always_inline Andi Kleen
2013-08-16 21:17 ` [PATCH 6/6] sched: Inline the need_resched test into the caller for _cond_resched Andi Kleen
2013-08-28 9:29 ` Improve preempt-scheduling and x86 user access v3 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827165011.b46c71b618e5cdc444af2804@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).