From: Ingo Molnar <mingo@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jean Pihet <jean.pihet@linaro.org>,
Josh Boyer <jwboyer@fedoraproject.org>,
Masanari Iida <standby24x7@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [GIT PULL 0/4] perf/urgent fixes
Date: Fri, 25 Apr 2014 10:12:01 +0200 [thread overview]
Message-ID: <20140425081201.GA24787@gmail.com> (raw)
In-Reply-To: <20140424114700.GE1110@krava.brq.redhat.com>
* Jiri Olsa <jolsa@redhat.com> wrote:
> SNIP
>
> >
> > Okay, so the problem is that we don't have a simple binary-state
> > feature in this case, but three possible states: 'libunwind', or
> > 'libdw-dwarf-unwind', or 'OFF', right?
> >
> > If so then the solution would be to replace those 3 last lines with
> > just this line:
> >
> > ... DWARF unwind library: [ libunwind ]
> >
> > Where 'libunwind' is printed in green (like the 'on' lines are
> > printed). If there's no suitable library available then output:
> >
> > ... DWARF unwind library: [ OFF ]
> >
> > Because the user looking at the output is really only interested in
> > 'is an unwind library available', and maybe in 'which one'.
> >
> > Is there preference between library choices? I.e. is 'libunwind'
> > preferred over 'libdw-dwarf-unwind', or the other way around? If yes
> > then if we pick an inferior library we could print it in yellow color
> > - and only use green if it's the 'best' choice.
> >
> > That way the color codes also still keep working: red means problem,
> > green means OK, yellow something inbetween.
>
> sounds good.. TODO list updated ;-)
>
> >
> > But in any case we should try to keep the 'one feature, one line'
> > fundamental output concept.
> >
> > ( Under V=1 we can output whatever details might be useful to
> > developers, there's no restriction on what to output there. )
>
> thats what we put VF for.. maybe we should for verbose
> features code detection output for V=1 as well
Yeah, I think it's only rarely needed, so might make sense to merge it
into V=1.
Thanks,
Ingo
next prev parent reply other threads:[~2014-04-25 8:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 11:31 [GIT PULL 0/4] perf/urgent fixes Jiri Olsa
2014-04-23 11:31 ` [PATCH 1/4] perf tests x86: Fix memory leak in sample_ustack() Jiri Olsa
2014-04-23 11:31 ` [PATCH 2/4] perf tools: Disable libdw unwind for all but x86 arch Jiri Olsa
2014-04-23 11:31 ` [PATCH 3/4] tools lib traceevent: Fix backward compatibility macros for pevent filter enums Jiri Olsa
2014-04-23 11:31 ` [PATCH 4/4] tools lib traceevent: Fix memory leak in pretty_print() Jiri Olsa
2014-04-23 13:09 ` [GIT PULL 0/4] perf/urgent fixes Ingo Molnar
2014-04-23 13:14 ` Ingo Molnar
2014-04-23 13:49 ` Jiri Olsa
2014-04-24 6:36 ` Ingo Molnar
2014-04-24 11:47 ` Jiri Olsa
2014-04-25 8:12 ` Ingo Molnar [this message]
2014-04-23 14:53 ` Jiri Olsa
2014-04-24 6:47 ` Ingo Molnar
2014-04-24 11:43 ` Jiri Olsa
2014-04-25 17:50 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2018-06-02 14:59 Arnaldo Carvalho de Melo
2018-06-03 17:12 ` Ingo Molnar
2017-05-04 17:23 Arnaldo Carvalho de Melo
2017-05-04 17:44 ` Ingo Molnar
2016-01-26 14:32 Arnaldo Carvalho de Melo
2016-01-30 8:16 ` Ingo Molnar
2015-08-19 19:40 Arnaldo Carvalho de Melo
2015-08-20 9:48 ` Ingo Molnar
2015-07-09 15:45 Arnaldo Carvalho de Melo
2015-07-10 8:04 ` Ingo Molnar
2015-04-23 22:03 Arnaldo Carvalho de Melo
2015-04-24 2:02 ` Namhyung Kim
2015-04-24 2:09 ` Arnaldo Carvalho de Melo
2015-04-24 8:59 ` Javi Merino
2015-04-24 16:02 ` Arnaldo Carvalho de Melo
2015-04-24 16:05 ` Will Deacon
2015-01-03 2:55 Arnaldo Carvalho de Melo
2015-01-08 8:00 ` Ingo Molnar
2013-10-28 19:16 Arnaldo Carvalho de Melo
2013-10-29 8:10 ` Ingo Molnar
2012-05-30 0:11 Arnaldo Carvalho de Melo
2012-05-30 7:00 ` Ingo Molnar
2012-05-25 19:59 Arnaldo Carvalho de Melo
2012-05-25 21:46 ` Arnaldo Carvalho de Melo
2012-04-20 16:53 Arnaldo Carvalho de Melo
2012-04-25 7:08 ` Ingo Molnar
2012-03-01 17:25 Arnaldo Carvalho de Melo
2011-06-03 16:25 Arnaldo Carvalho de Melo
2011-06-04 10:13 ` Ingo Molnar
2011-06-04 10:29 ` Ingo Molnar
2010-12-16 12:00 Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425081201.GA24787@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jean.pihet@linaro.org \
--cc=jolsa@redhat.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).