From: Andrew Morton <akpm@linux-foundation.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Jan Kara <jack@suse.cz>, Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Paris <eparis@parisplace.org>,
John McCutchan <john@johnmccutchan.com>,
Robert Love <rlove@rlove.org>,
Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: [PATCH 1/1] fallocate: create FAN_MODIFY and IN_MODIFY events
Date: Tue, 14 Oct 2014 15:43:49 -0700 [thread overview]
Message-ID: <20141014154349.ca831a4d1e5c1747779552ec@linux-foundation.org> (raw)
In-Reply-To: <54342FC2.7030509@gmx.de>
On Tue, 07 Oct 2014 20:24:02 +0200 Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> Hello Andrew,
>
> the patch in
> https://lkml.org/lkml/2014/10/3/56
> and cited below was reviewed by Jan Kara.
>
Jan wondered why we generate events for FALLOC_FL_KEEP_SIZE, so other
people will wonder the same thing. We should tell them. Via code
comments and/or changelogging.
Any question which a reviewer asks should be viewed as a defect in the
patch. The patch isn't finished until people can read it without
having questions.
next prev parent reply other threads:[~2014-10-14 22:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1412287587-5392-1-git-send-email-xypron.glpk@gmx.de>
2014-10-03 8:19 ` [PATCH 1/1] fallocate: create FAN_MODIFY and IN_MODIFY events Heinrich Schuchardt
2014-10-06 14:12 ` Jan Kara
2014-10-06 19:10 ` Heinrich Schuchardt
2014-10-07 18:05 ` Jan Kara
2014-10-07 18:24 ` Heinrich Schuchardt
2014-10-14 22:43 ` Andrew Morton [this message]
2014-10-17 17:08 ` [PATCH v2 " Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014154349.ca831a4d1e5c1747779552ec@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=eparis@parisplace.org \
--cc=jack@suse.cz \
--cc=john@johnmccutchan.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=rlove@rlove.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).