From: Pavel Machek <pavel@ucw.cz>
To: "Andreas Färber" <afaerber@suse.de>
Cc: pali.rohar@gmail.com, sre@debian.org, sre@ring0.de,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, freemangordon@abv.bg,
bcousson@baylibre.com, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, sakari.ailus@iki.fi,
devicetree@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [RFC] adp1653: Add device tree bindings for LED controller
Date: Sun, 16 Nov 2014 11:15:48 +0100 [thread overview]
Message-ID: <20141116101548.GB32483@amd> (raw)
In-Reply-To: <546877EF.8010906@suse.de>
On Sun 2014-11-16 11:09:51, Andreas Färber wrote:
> Hi Pavel,
>
> Am 16.11.2014 um 08:59 schrieb Pavel Machek:
> > For device tree people: Yes, I know I'll have to create file in
> > documentation, but does the binding below look acceptable?
> [...]
> > diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> > index 739fcf2..ed0bfc1 100644
> > --- a/arch/arm/boot/dts/omap3-n900.dts
> > +++ b/arch/arm/boot/dts/omap3-n900.dts
> > @@ -553,6 +561,18 @@
> >
> > ti,usb-charger-detection = <&isp1704>;
> > };
> > +
> > + adp1653: adp1653@30 {
>
> This should probably be led-controller@30 (a generic description not
> specific to the model). The label name is fine.
Thanks.
> > + gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* Want 88 */
>
> At least to me, the meaning of "Want 88" is not clear - drop or clarify?
I changed it to /* 88 */ to match rest of code.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-11-16 10:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 7:59 [RFC] adp1653: Add device tree bindings for LED controller Pavel Machek
2014-11-16 8:11 ` Lars-Peter Clausen
2014-11-16 8:43 ` Pavel Machek
2014-11-16 10:09 ` Andreas Färber
2014-11-16 10:15 ` Pavel Machek [this message]
2014-11-17 8:43 ` Pali Rohár
2014-11-17 10:05 ` Pavel Machek
2014-11-17 10:09 ` Pali Rohár
2014-11-17 10:15 ` Pavel Machek
2014-11-17 14:55 ` Tony Lindgren
2014-11-17 15:01 ` Pali Rohár
2014-11-17 15:04 ` Sakari Ailus
2014-11-17 15:15 ` Pali Rohár
2014-11-22 18:45 ` Ivaylo Dimitrov
2014-11-17 15:06 ` Tony Lindgren
2014-11-17 15:21 ` Pali Rohár
2014-11-18 18:35 ` Pavel Machek
2014-11-19 18:01 ` Sakari Ailus
2014-11-17 14:58 ` Sakari Ailus
2014-11-18 8:09 ` Jacek Anaszewski
2014-11-18 8:46 ` Pavel Machek
2014-11-18 10:04 ` Jacek Anaszewski
2014-11-18 11:32 ` Pavel Machek
2014-11-18 12:52 ` Jacek Anaszewski
2014-11-18 13:21 ` Pavel Machek
2014-11-18 16:02 ` Jacek Anaszewski
2014-11-18 16:51 ` Pavel Machek
2014-11-19 9:45 ` Jacek Anaszewski
2014-11-19 17:53 ` Sakari Ailus
2014-11-20 9:21 ` Jacek Anaszewski
2014-11-20 12:13 ` Pavel Machek
2014-11-20 12:12 ` Pavel Machek
2014-11-20 12:48 ` Jacek Anaszewski
2014-11-20 12:38 ` Jacek Anaszewski
2014-11-18 8:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141116101548.GB32483@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=afaerber@suse.de \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=freemangordon@abv.bg \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pali.rohar@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sre@debian.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).