From: Steven Rostedt <rostedt@goodmis.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH 2/3] tracing: Move enabling tracepoints to just after mm_init()
Date: Sun, 14 Dec 2014 13:20:20 -0500 [thread overview]
Message-ID: <20141214132020.4ddf323b@gandalf.local.home> (raw)
In-Reply-To: <20141214181444.GE5310@linux.vnet.ibm.com>
On Sun, 14 Dec 2014 10:14:44 -0800
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
> > diff --git a/init/main.c b/init/main.c
> > index 800a0daede7e..060e60b6aa59 100644
> > --- a/init/main.c
> > +++ b/init/main.c
> > @@ -561,6 +561,9 @@ asmlinkage __visible void __init start_kernel(void)
> > trap_init();
> > mm_init();
> >
> > + /* trace_printk() and trace points may be used after this */
> > + trace_init();
>
> Or if you aren't going to use call_rcu_sched() before this point, I could
> move the call_rcu_sched()-relevant initialization to this point. Or make
> the compiler do it -- I am pretty sure that the per-CPU variables are in
> place at this point.
>
Well, we could move trace_init() after rcu_init() for now too, and
remove my tracepoint patch. But I'd like to have trace_init() go before
sched_init() since that could possibly use debugging tracepoints as
well.
So if you could add a rcu_partial_init() that makes calling
call_rcu_sched() work, that would be great. That could be for 3.20
then, and for now, I just move trace_init() after rcu_init() which is
still before irq_init() that Thomas needs for his work.
-- Steve
next prev parent reply other threads:[~2014-12-14 18:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 16:41 [PATCH 0/3] tracing: Enable tracepoints early and allow printk to use them Steven Rostedt
2014-12-14 16:41 ` [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall() Steven Rostedt
2014-12-14 16:53 ` Steven Rostedt
2014-12-14 18:08 ` Paul E. McKenney
2014-12-14 18:15 ` Steven Rostedt
2014-12-14 18:18 ` Paul E. McKenney
2014-12-14 18:25 ` Steven Rostedt
2014-12-14 20:23 ` Paul E. McKenney
2014-12-14 17:05 ` Mathieu Desnoyers
2014-12-14 17:14 ` Steven Rostedt
2014-12-14 17:21 ` Steven Rostedt
2014-12-14 17:29 ` Mathieu Desnoyers
2014-12-14 17:44 ` Steven Rostedt
2014-12-14 18:13 ` Paul E. McKenney
2014-12-14 16:41 ` [PATCH 2/3] tracing: Move enabling tracepoints to just after mm_init() Steven Rostedt
2014-12-14 18:14 ` Paul E. McKenney
2014-12-14 18:20 ` Steven Rostedt [this message]
2014-12-14 20:26 ` Paul E. McKenney
2014-12-14 16:41 ` [PATCH 3/3] tracing: Add tp_printk cmdline to have tracepoints go to printk() Steven Rostedt
2014-12-14 17:07 ` [PATCH 0/3] tracing: Enable tracepoints early and allow printk to use them Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141214132020.4ddf323b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).