From: Guenter Roeck <linux@roeck-us.net>
To: Robert Rosengren <robert.rosengren@axis.com>
Cc: Jean Delvare <jdelvare@suse.de>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
Johan Adolfsson <johana@axis.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable
Date: Tue, 27 Jan 2015 12:05:53 -0800 [thread overview]
Message-ID: <20150127200553.GA5689@roeck-us.net> (raw)
In-Reply-To: <4BEA3FF3CAA35E408EA55C7BE2E61D05943B6DD753@xmail3.se.axis.com>
On Tue, Jan 27, 2015 at 08:54:34PM +0100, Robert Rosengren wrote:
> Guenter and Jean,
>
> To sum up, my problems was related my kernel and hardware configuration, and it now works. Many thanks for your input!
>
> However, the values retrieved from hwmon sysfs is not the same as before the regmap patch. Guenter, the byte swap for the regval retrieved by regmap_read. In what order is the bits returned from that function, because it seems as if I disabled that code I get values as I expect (i.e. before the regmap patch).
>
Trying to understand. Are you saying everything works as expected
if you keep byte_swap set to false ?
That might well be, though it might mean that regmap has a bug
in how it treats i2c word read operations. I'll have to look into it
some more.
Can you send me your diffs on top of mine to help me understand what
you changed ?
Thanks,
Guenter
next prev parent reply other threads:[~2015-01-27 20:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 12:05 [PATCH] hwmon: (ads7828) Make sample interval configurable Robert Rosengren
2015-01-16 14:52 ` Guenter Roeck
2015-01-16 18:30 ` [lm-sensors] " Guenter Roeck
2015-01-19 11:14 ` SV: " Robert Rosengren
2015-01-27 7:59 ` Robert Rosengren
2015-01-27 10:37 ` Jean Delvare
2015-01-27 14:23 ` Guenter Roeck
2015-01-27 14:07 ` Guenter Roeck
2015-01-27 19:54 ` Robert Rosengren
2015-01-27 20:05 ` Guenter Roeck [this message]
2015-01-27 22:34 ` Jean Delvare
2015-01-28 4:06 ` Guenter Roeck
[not found] ` <54C87F3C.2020105@axis.com>
2015-01-28 6:28 ` Robert Rosengren
2015-01-28 14:50 ` Guenter Roeck
2015-01-29 7:00 ` Robert Rosengren
2015-01-29 7:05 ` Guenter Roeck
2015-01-29 12:07 ` Robert Rosengren
2015-01-29 14:10 ` Guenter Roeck
2015-01-29 19:30 ` Guenter Roeck
2015-01-31 20:11 ` Guenter Roeck
2015-02-02 8:12 ` Robert Rosengren
2015-02-02 16:21 ` Guenter Roeck
2015-01-27 14:26 ` Guenter Roeck
2015-01-27 16:37 ` Guenter Roeck
2015-01-16 20:30 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127200553.GA5689@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.de \
--cc=johana@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=robert.rosengren@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).