From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jan Beulich <JBeulich@suse.com>,
tglx@linutronix.de, torvalds@linux-foundation.org,
riel@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [tip:sched/urgent] sched/fair: Avoid using uninitialized variable in preferred_group_nid()
Date: Mon, 9 Feb 2015 09:21:15 +0100 [thread overview]
Message-ID: <20150209082115.GA32322@gmail.com> (raw)
In-Reply-To: <20150128153754.GG23038@twins.programming.kicks-ass.net>
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Wed, Jan 28, 2015 at 02:46:19PM +0000, Jan Beulich wrote:
> > >>> On 28.01.15 at 15:29, <tipbot@zytor.com> wrote:
> > > Commit-ID: 81907478c4311a679849216abf723999184ab984
> > > Gitweb:
> > > http://git.kernel.org/tip/81907478c4311a679849216abf723999184ab984
> > > Author: Jan Beulich <JBeulich@suse.com>
> > > AuthorDate: Fri, 23 Jan 2015 08:25:38 +0000
> > > Committer: Ingo Molnar <mingo@kernel.org>
> > > CommitDate: Wed, 28 Jan 2015 13:14:12 +0100
> > >
> > > sched/fair: Avoid using uninitialized variable in preferred_group_nid()
> > >
> > > At least some gcc versions - validly afaict - warn about potentially
> > > using max_group uninitialized: There's no way the compiler can prove
> > > that the body of the conditional where it and max_faults get set/
> > > updated gets executed; in fact, without knowing all the details of
> > > other scheduler code, I can't prove this either.
> > >
> > > Generally the necessary change would appear to be to clear max_group
> > > prior to entering the inner loop, and break out of the outer loop when
> > > it ends up being all clear after the inner one. This, however, seems
> > > inefficient, and afaict the same effect can be achieved by exiting the
> > > outer loop when max_faults is still zero after the inner loop.
> > >
> > > [ mingo: changed the solution to zero initialization: uninitialized_var()
> > > needs to die, as it's an actively dangerous construct: if in the future
> > > a known-proven-good piece of code is changed to have a true, buggy
> > > uninitialized variable, the compiler warning is then supressed...
> >
> > But you went farther than that: You also dropped the breaking
> > out of the outer loop. Yet that has - beyond the fixing of the bug
> > here - the desirable effect of not continuing for perhaps many
> > iterations when nothing new can ever be found anymore.
>
> That break is indeed desired. The 'problem' it fixes is
> that when group_faults() returns 0, faults will be 0,
> which will not > max_faults, and therefore we will not
> set max_group.
>
> Without that break, we'll now set nodes to
> NODE_MASK_NONE, which will mean the for_each_node(a,
> nodes) loop will NOP and our dist loop will iterate
> pointlessly.
Ok, agreed, please send a separate patch to fix this.
Thanks,
Ingo
next prev parent reply other threads:[~2015-02-09 8:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 8:25 sched/fair: avoid using uninitialized variable in preferred_group_nid() Jan Beulich
2015-01-23 9:54 ` Peter Zijlstra
2015-01-23 10:01 ` Jan Beulich
2015-01-28 14:29 ` [tip:sched/urgent] sched/fair: Avoid " tip-bot for Jan Beulich
2015-01-28 14:46 ` Jan Beulich
2015-01-28 15:37 ` Peter Zijlstra
2015-02-09 8:21 ` Ingo Molnar [this message]
2015-02-09 11:37 ` Peter Zijlstra
2015-02-09 11:41 ` Jan Beulich
2015-02-18 17:10 ` [tip:sched/core] sched/numa: Avoid some pointless iterations tip-bot for Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150209082115.GA32322@gmail.com \
--to=mingo@kernel.org \
--cc=JBeulich@suse.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).