From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio: drop a useless config read
Date: Tue, 31 Mar 2015 15:02:01 +0200 [thread overview]
Message-ID: <20150331150201.34cb8823.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1427802906-7743-1-git-send-email-mst@redhat.com>
On Tue, 31 Mar 2015 13:55:42 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> commit d71de9ec6ba806104439d3a669befda84757b5af
> "virtio: core support for config generation"
> fixed reading up 64 bit values, adding generation
> checks for such reads.
>
> By mistake, it left an explicit get call in place
> as well. the result is that the value is read twice,
> the first result is discarded.
>
> Not a big deal since this only happens with virtio
> blk and only on boot ATM, so performance isn't
> affected, but let's clean it up.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/linux/virtio_config.h | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2015-03-31 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 11:55 [PATCH] virtio: drop a useless config read Michael S. Tsirkin
2015-03-31 13:02 ` Cornelia Huck [this message]
2015-04-01 3:14 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331150201.34cb8823.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).