From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753773AbbDHMKW (ORCPT ); Wed, 8 Apr 2015 08:10:22 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:36721 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbbDHMKT (ORCPT ); Wed, 8 Apr 2015 08:10:19 -0400 Date: Wed, 8 Apr 2015 14:10:06 +0200 From: Peter Zijlstra To: Viresh Kumar Cc: Thomas Gleixner , Ingo Molnar , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, Preeti U Murthy Subject: Re: [PATCH V2 2/2] hrtimer: Iterate only over active clock-bases Message-ID: <20150408121006.GC23123@twins.programming.kicks-ass.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 07, 2015 at 07:40:53AM +0530, Viresh Kumar wrote: > At several instances we iterate over all possible clock-bases for a > particular cpu-base. Whereas, we only need to iterate over active bases. > > We already have per cpu-base 'active_bases' field, which is updated on > addition/removal of hrtimers. > > This patch creates for_each_active_base(), which uses 'active_bases' to > iterate only over active bases. > > This also updates code which iterates over clock-bases. This Changelog is very thin on compelling reasons to do this. Not to mention you did no analysis on the code generated.