From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753945AbbDPQEj (ORCPT ); Thu, 16 Apr 2015 12:04:39 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:33323 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753307AbbDPQEX (ORCPT ); Thu, 16 Apr 2015 12:04:23 -0400 Date: Thu, 16 Apr 2015 12:04:21 -0400 (EDT) Message-Id: <20150416.120421.898004929174813546.davem@davemloft.net> To: tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@kernel.org, preeti@linux.vnet.ibm.com, viresh.kumar@linaro.org, mtosatt@redhat.com, fweisbec@gmail.com, netdev@vger.kernel.org Subject: Re: [patch 31/39] net: core: pktgen: Remove bogus hrtimer_active() check From: David Miller In-Reply-To: <20150414203503.165258315@linutronix.de> References: <20150414203303.702062272@linutronix.de> <20150414203503.165258315@linutronix.de> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 16 Apr 2015 09:04:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Gleixner Date: Tue, 14 Apr 2015 21:09:16 -0000 > The check for hrtimer_active() after starting the timer is > pointless. If the timer is inactive it has expired already and > therefor the task pointer is already NULL. > > Signed-off-by: Thomas Gleixner Acked-by: David S. Miller