From: Aristeu Rozanski <aris@redhat.com>
To: lukasz.anaczkowski@intel.com
Cc: mchehab@osg.samsung.com, dougthompson@xmission.com, bp@alien8.de,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
Jim Snow <jim.m.snow@intel.com>
Subject: Re: [PATCH 2/3] sb_edac: virtualize several hard-coded functions
Date: Fri, 12 Jun 2015 09:30:26 -0400 [thread overview]
Message-ID: <20150612133025.GG14408@redhat.com> (raw)
In-Reply-To: <1433850192-9866-3-git-send-email-lukasz.anaczkowski@intel.com>
Hi Jim, Lukasz,
On Tue, Jun 09, 2015 at 01:43:11PM +0200, lukasz.anaczkowski@intel.com wrote:
> @@ -273,6 +270,10 @@ struct sbridge_info {
> u64 (*get_tolm)(struct sbridge_pvt *pvt);
> u64 (*get_tohm)(struct sbridge_pvt *pvt);
> u64 (*rir_limit)(u32 reg);
> + u64 (*sad_limit)(u32 reg);
> + u32 (*interleave_mode)(u32 reg);
> + char* (*show_interleave_mode)(u32 reg);
> + u32 (*dram_attr)(u32 reg);
> const u32 *dram_rule;
> const u32 *interleave_list;
> const struct interleave_pkg *interleave_pkg;
the only reason these exist is for when there's a difference between
memory controllers:
> pvt->info.get_memory_type = get_memory_type;
> pvt->info.get_memory_type = get_memory_type;
> pvt->info.get_memory_type = haswell_get_memory_type;
until then such change isn't really necessary.
--
Aristeu
next prev parent reply other threads:[~2015-06-12 13:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 11:43 [PATCH 0/3] EDAC: add DDR4 flag, misc improvements lukasz.anaczkowski
2015-06-09 11:43 ` [PATCH 1/3] EDAC: add DDR4 flag lukasz.anaczkowski
2015-06-09 11:43 ` [PATCH 2/3] sb_edac: virtualize several hard-coded functions lukasz.anaczkowski
2015-06-12 13:30 ` Aristeu Rozanski [this message]
2015-06-15 8:06 ` Anaczkowski, Lukasz
2015-06-09 11:43 ` [PATCH 3/3] sb_edac: support for duplicate device IDs lukasz.anaczkowski
2015-06-09 11:50 ` [PATCH 0/3] EDAC: add DDR4 flag, misc improvements Borislav Petkov
2015-06-09 11:54 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612133025.GG14408@redhat.com \
--to=aris@redhat.com \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=jim.m.snow@intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.anaczkowski@intel.com \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).