From: Steven Rostedt <rostedt@goodmis.org>
To: Tal Shorer <tal.shorer@gmail.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [Patch RFC 1/2] tracing: allow disabling compilation of specific trace systems
Date: Mon, 13 Jul 2015 14:34:59 -0400 [thread overview]
Message-ID: <20150713143459.09582cb9@gandalf.local.home> (raw)
In-Reply-To: <1434831679-3852-2-git-send-email-tal.shorer@gmail.com>
On Sat, 20 Jun 2015 23:21:18 +0300
Tal Shorer <tal.shorer@gmail.com> wrote:
> Allow a trace events header file to disable compilation of its
> trace events by defining the preprocessor macro NOTRACE.
>
> This could be done, for example, according to a Kconfig option.
>
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
> ---
> include/linux/tracepoint.h | 6 +++---
> include/trace/define_trace.h | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
> index a5f7f3e..c869f84 100644
> --- a/include/linux/tracepoint.h
> +++ b/include/linux/tracepoint.h
> @@ -111,7 +111,7 @@ extern void syscall_unregfunc(void);
> #define TP_ARGS(args...) args
> #define TP_CONDITION(args...) args
>
> -#ifdef CONFIG_TRACEPOINTS
> +#if defined(CONFIG_TRACEPOINTS) && !defined(NOTRACE)
Instead of the duplicate condition above, it would be better to make a
new macro at the top. And we can add a nice comment to it as well.
/*
* Individual subsystem my have a separate configuration to
* enable their tracepoints. By default, this file will create
* the tracepoints if CONFIG_TRACEPOINT is defined. If a subsystem
* wants to be able to disable its tracepoints from being created
* it can define NOTRACE before including the tracepoint headers.
*/
#if defined(CONFIG_TRACEPOINTS) && !defined(NOTRACE)
# define TRACEPOINTS_ENABLED
#endif
Then switch all the conditions below to:
#ifdef TRACEPOINTS_ENABLED
-- Steve
>
> /*
> * it_func[0] is never NULL because there is at least one element in the array
> @@ -234,7 +234,7 @@ extern void syscall_unregfunc(void);
> #define EXPORT_TRACEPOINT_SYMBOL(name) \
> EXPORT_SYMBOL(__tracepoint_##name)
>
> -#else /* !CONFIG_TRACEPOINTS */
> +#else /* !(defined(CONFIG_TRACEPOINTS) && !defined(NOTRACE)) */
> #define __DECLARE_TRACE(name, proto, args, cond, data_proto, data_args) \
> static inline void trace_##name(proto) \
> { } \
> @@ -266,7 +266,7 @@ extern void syscall_unregfunc(void);
> #define EXPORT_TRACEPOINT_SYMBOL_GPL(name)
> #define EXPORT_TRACEPOINT_SYMBOL(name)
>
> -#endif /* CONFIG_TRACEPOINTS */
> +#endif /* defined(CONFIG_TRACEPOINTS) && !defined(NOTRACE) */
>
> #ifdef CONFIG_TRACING
> /**
> diff --git a/include/trace/define_trace.h b/include/trace/define_trace.h
> index 02e1003..e847fd7 100644
> --- a/include/trace/define_trace.h
> +++ b/include/trace/define_trace.h
> @@ -86,7 +86,7 @@
> #undef DECLARE_TRACE
> #define DECLARE_TRACE(name, proto, args)
>
> -#ifdef CONFIG_EVENT_TRACING
> +#if defined(CONFIG_EVENT_TRACING) && !defined(NOTRACE)
> #include <trace/ftrace.h>
> #endif
>
next prev parent reply other threads:[~2015-07-13 18:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 20:21 [Patch RFC 0/2] tracing: allow disabling compilation of specific trace systems Tal Shorer
2015-06-20 20:21 ` [Patch RFC 1/2] " Tal Shorer
2015-07-13 18:34 ` Steven Rostedt [this message]
2015-07-13 21:38 ` Tal Shorer
2015-07-16 17:39 ` [PATCH v2 0/2] " Tal Shorer
2015-07-16 17:39 ` [PATCH v2 1/2] " Tal Shorer
2015-07-16 17:39 ` [PATCH v2 2/2] tracing: gpio: add Kconfig option for enabling/disabling trace events Tal Shorer
2015-07-17 18:36 ` Steven Rostedt
2015-07-18 10:12 ` Tal Shorer
2015-08-01 12:27 ` [Patch v3 0/2] tracing: allow disabling compilation of specific trace systems Tal Shorer
2015-08-01 12:27 ` [Patch v3 1/2] " Tal Shorer
2015-08-01 12:27 ` [Patch v3 2/2] tracing: gpio: add Kconfig option for enabling/disabling trace events Tal Shorer
2015-08-11 19:45 ` Tal Shorer
2015-09-23 14:54 ` Tal Shorer
2019-03-27 16:12 ` Uwe Kleine-König
2019-04-05 17:25 ` Linus Walleij
2015-07-27 11:57 ` [PATCH v2 " Linus Walleij
2015-06-20 20:21 ` [Patch RFC " Tal Shorer
2015-06-25 20:41 ` [Patch RFC 0/2] tracing: allow disabling compilation of specific trace systems Tal Shorer
2015-06-25 22:25 ` Steven Rostedt
2015-07-06 16:53 ` Tal Shorer
-- strict thread matches above, loose matches on Subject: below --
2015-06-13 21:00 Tal Shorer
2015-06-13 21:00 ` [Patch RFC 1/2] " Tal Shorer
2015-06-08 19:04 [Patch RFC 0/2] " Tal Shorer
2015-06-08 19:04 ` [Patch RFC 1/2] " Tal Shorer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713143459.09582cb9@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tal.shorer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).