From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
"Chris Zhong" <zyw@rock-chips.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: linux-next: build failure after merge of the gpio tree
Date: Tue, 21 Jul 2015 13:29:45 +1000 [thread overview]
Message-ID: <20150721132945.7ffc443b@canb.auug.org.au> (raw)
Hi Linus,
After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/regulator/rk808-regulator.c: In function 'rk808_regulator_dt_parse_pdata':
drivers/regulator/rk808-regulator.c:543:24: error: too few arguments to function 'gpiod_get_index'
pdata->dvs_gpio[i] = gpiod_get_index(client_dev, "dvs", i);
^
In file included from include/asm-generic/gpio.h:13:0,
from include/linux/gpio.h:51,
from drivers/regulator/rk808-regulator.c:20:
include/linux/gpio/consumer.h:53:32: note: declared here
struct gpio_desc *__must_check gpiod_get_index(struct device *dev,
^
Caused by commit
bad47ad2eef3 ("regulator: rk808: fixed the overshoot when adjust voltage")
from the regulator tree interactings with commit
b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
from the gpio tree.
I added teh following merge fix patch:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 21 Jul 2015 13:23:56 +1000
Subject: [PATCH] regulator: rk808: fix up for gpiod_get_index() API change
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/regulator/rk808-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c
index ca913fd15598..cfec52c1a4a2 100644
--- a/drivers/regulator/rk808-regulator.c
+++ b/drivers/regulator/rk808-regulator.c
@@ -540,7 +540,7 @@ static int rk808_regulator_dt_parse_pdata(struct device *dev,
goto dt_parse_end;
for (i = 0; i < ARRAY_SIZE(pdata->dvs_gpio); i++) {
- pdata->dvs_gpio[i] = gpiod_get_index(client_dev, "dvs", i);
+ pdata->dvs_gpio[i] = gpiod_get_index(client_dev, "dvs", i, GPIOD_ASIS);
if (IS_ERR(pdata->dvs_gpio[i])) {
dev_warn(dev, "there is no dvs%d gpio\n", i);
continue;
--
2.1.4
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
next reply other threads:[~2015-07-21 3:29 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 3:29 Stephen Rothwell [this message]
2015-07-21 6:59 ` [PATCH] regulator: rk808: make better use of the gpiod API Uwe Kleine-König
2015-07-21 9:56 ` Linus Walleij
2015-07-21 11:04 ` Mark Brown
2015-07-21 14:21 ` Uwe Kleine-König
2015-07-21 14:46 ` [PATCH 1/2] regulator: rk808: add #include for gpiod functions Uwe Kleine-König
2015-07-21 14:46 ` [PATCH v2 2/2] regulator: rk808: make better use of the gpiod API Uwe Kleine-König
2015-07-22 2:21 ` Krzysztof Kozlowski
2015-07-21 13:09 ` [PATCH] " Krzysztof Kozlowski
2015-07-21 14:35 ` Uwe Kleine-König
2015-07-21 14:41 ` Mark Brown
2015-07-21 15:08 ` [PATCH] base/platform: assert that dev_pm_domain callbacks are called unconditionally Uwe Kleine-König
2015-08-06 0:06 ` Greg Kroah-Hartman
2015-07-22 0:13 ` [PATCH] regulator: rk808: make better use of the gpiod API Krzysztof Kozlowski
2015-07-22 7:13 ` Uwe Kleine-König
-- strict thread matches above, loose matches on Subject: below --
2020-11-18 3:30 linux-next: build failure after merge of the gpio tree Stephen Rothwell
2020-11-18 7:50 ` Linus Walleij
2020-04-01 4:19 Stephen Rothwell
2020-04-01 7:49 ` Geert Uytterhoeven
2020-04-01 7:57 ` Stephen Rothwell
2020-04-01 8:18 ` Linus Walleij
2020-04-01 8:24 ` Geert Uytterhoeven
2020-04-01 12:29 ` Andy Shevchenko
2020-04-01 12:30 ` Andy Shevchenko
2020-04-01 8:19 ` Linus Walleij
2020-03-30 7:58 Stephen Rothwell
2020-03-30 6:11 Stephen Rothwell
2019-08-16 11:38 Stephen Rothwell
2019-08-16 22:25 ` Linus Walleij
2018-12-17 8:24 Stephen Rothwell
2018-12-10 7:00 Stephen Rothwell
2017-11-02 5:20 Stephen Rothwell
2017-11-02 5:33 ` Masahiro Yamada
2017-11-03 7:50 ` Linus Walleij
2017-11-03 8:13 ` Stephen Rothwell
2017-11-03 21:40 ` Linus Walleij
2017-11-13 11:33 ` Stephen Rothwell
2017-11-13 13:40 ` Masahiro Yamada
2017-06-21 6:09 Stephen Rothwell
2017-06-21 6:12 ` Jisheng Zhang
2017-06-21 7:41 ` Linus Walleij
2017-05-29 5:39 Stephen Rothwell
2017-05-29 8:11 ` Linus Walleij
2017-02-08 5:11 Stephen Rothwell
2017-02-08 8:48 ` Lee Jones
2017-02-08 9:05 ` Boris Brezillon
2017-02-08 10:30 ` Stephen Rothwell
2017-02-13 15:18 ` Linus Walleij
2016-09-09 4:36 Stephen Rothwell
2016-09-12 13:27 ` Linus Walleij
2016-04-18 4:10 Stephen Rothwell
2016-03-31 2:22 Stephen Rothwell
2016-03-31 7:52 ` Linus Walleij
2016-02-16 3:48 Stephen Rothwell
2016-02-16 14:47 ` Linus Walleij
2016-01-29 1:45 Stephen Rothwell
2016-02-04 2:16 ` Stephen Rothwell
2016-02-08 17:36 ` Linus Walleij
2015-12-22 5:42 Stephen Rothwell
2015-12-22 6:57 ` Robert Jarzmik
2015-12-22 9:08 ` Linus Walleij
2015-12-22 20:10 ` Stephen Rothwell
2015-12-22 23:58 ` Linus Walleij
2015-12-23 0:20 ` Stephen Rothwell
2015-12-16 3:37 Stephen Rothwell
2015-12-16 3:55 ` Yendapally Reddy Dhananjaya Reddy
2015-12-21 5:02 ` Stephen Rothwell
2015-12-21 8:46 ` Linus Walleij
2015-12-02 23:38 Mark Brown
2015-08-31 6:40 Stephen Rothwell
2015-08-31 6:49 ` Linus Walleij
2015-08-18 6:57 Stephen Rothwell
2015-08-18 12:00 ` Linus Walleij
2015-08-18 12:23 ` Uwe Kleine-König
2015-08-18 13:35 ` Mauro Carvalho Chehab
2015-08-12 8:10 Stephen Rothwell
2015-08-12 8:21 ` Uwe Kleine-König
2015-08-12 12:27 ` Stephen Rothwell
2015-08-12 15:03 ` Stephen Rothwell
2015-08-12 20:16 ` Uwe Kleine-König
2015-08-12 23:02 ` Stephen Rothwell
2015-08-13 0:19 ` Chanwoo Choi
2015-08-13 0:50 ` Stephen Rothwell
2015-08-12 6:59 Stephen Rothwell
2015-08-10 5:07 Stephen Rothwell
2015-08-10 5:46 ` Dmitry Torokhov
2015-08-10 22:51 ` Stephen Rothwell
2015-05-13 6:55 Stephen Rothwell
2015-05-13 7:04 ` Alexandre Courbot
2015-05-13 7:36 ` Johan Hovold
2015-04-10 9:08 Stephen Rothwell
2015-04-10 9:35 ` Linus Walleij
2014-07-29 8:31 Stephen Rothwell
2014-07-29 8:42 ` Thierry Reding
2014-08-04 4:10 ` Alexandre Courbot
2014-08-04 4:28 ` Stephen Rothwell
2014-05-14 7:13 Stephen Rothwell
2014-05-16 15:54 ` Linus Walleij
2014-01-20 5:42 Stephen Rothwell
2013-09-18 3:12 Stephen Rothwell
2013-09-18 11:24 ` Linus Walleij
2013-03-04 1:45 Stephen Rothwell
2013-03-04 2:30 ` Linus Walleij
2013-03-04 2:32 ` Grant Likely
2012-02-03 2:54 Stephen Rothwell
2012-02-03 23:18 ` Grant Likely
2012-02-04 12:10 ` Mark Brown
2011-10-06 3:48 Stephen Rothwell
2011-10-11 6:37 ` Stephen Rothwell
2011-10-11 7:02 ` Tomoya MORINAGA
2011-10-12 4:24 ` Stephen Rothwell
2011-10-12 5:29 ` Tomoya MORINAGA
2011-10-12 7:21 ` Nobuhiro Iwamatsu
2011-10-12 8:37 ` Tomoya MORINAGA
2011-10-13 3:57 ` Grant Likely
2011-10-13 8:22 ` Tomoya MORINAGA
2011-10-13 17:31 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721132945.7ffc443b@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).