From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Drokin, Oleg" <oleg.drokin@intel.com>
Cc: Shraddha Barke <shraddha.6596@gmail.com>,
"<devel@driverdev.osuosl.org> SUBSYSTEM"
<devel@driverdev.osuosl.org>,
"Dilger, Andreas" <andreas.dilger@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"HPDD-discuss@lists.01.org" <HPDD-discuss@ml01.01.org>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Al Viro <viro@zeniv.linux.org.uk>,
"Hammond, John" <john.hammond@intel.com>,
Frank Zago <fzago@cray.com>
Subject: Re: about ENOSYS
Date: Mon, 3 Aug 2015 09:21:58 -0700 [thread overview]
Message-ID: <20150803162158.GA30867@kroah.com> (raw)
In-Reply-To: <D7ABD589-0012-4CA2-BB2B-A7D4B9F589D6@intel.com>
On Mon, Aug 03, 2015 at 06:41:22AM +0000, Drokin, Oleg wrote:
> subject have been missing, so I filled in something.
>
> On Aug 3, 2015, at 2:18 AM, Shraddha Barke wrote:
>
> > From b67c6c20455b04b77447ab4561e44f1a75dd978d Mon Sep 17 00:00:00 2001
> > From: Shraddha Barke <shraddha.6596@gmail.com>
> > Date: Mon, 3 Aug 2015 11:34:19 +0530
> > Subject: [PATCH] Staging : lustre : Use -EINVAL instead of -ENOSYS
> >
> > ENOSYS means that a nonexistent system call was called. This should
> > not be used for invalid operations on otherwise valid syscalls.
> >
> > Use -EINVAL instead of -ENOSYS. This fixes checkpatch warning message:
> >
> > WARNING: ENOSYS means 'invalid syscall nr' and nothing else
>
> Is this really true, though?
> I know you are working off what the tool reports.
> But in reality people have been using ENOSYS to indicate
> "this thing that you want is not really available"
> Reading the define file we can see:
> /usr/include/asm-generic/errno.h:#define ENOSYS 38 /* Function not implemented */
>
> $ grep -r 'ENOSYS;' fs/ | wc -l
> 75
>
> So it's extensively used in the fs tree by existing code.
>
> Hmm…. Searching some more I arrived at commit e15f431f
> that changes the in-kernel comment and claims the "system call only stuff".
>
> So Greg, do you want Lustre to get rid of use of ENOSYS (all 16 users we have),
> or is it ok to leave them in?
For now I'd just leave it as-is.
next prev parent reply other threads:[~2015-08-03 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 6:18 Shraddha Barke
2015-08-03 6:41 ` about ENOSYS Drokin, Oleg
2015-08-03 16:21 ` Greg Kroah-Hartman [this message]
2015-08-03 7:12 ` your mail Sudip Mukherjee
2015-08-03 7:24 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803162158.GA30867@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=HPDD-discuss@ml01.01.org \
--cc=Julia.Lawall@lip6.fr \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=fzago@cray.com \
--cc=john.hammond@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=shraddha.6596@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).