From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755588AbbKCSbM (ORCPT ); Tue, 3 Nov 2015 13:31:12 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:46322 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbbKCSbK (ORCPT ); Tue, 3 Nov 2015 13:31:10 -0500 Date: Tue, 03 Nov 2015 13:31:07 -0500 (EST) Message-Id: <20151103.133107.8373482880165720.davem@davemloft.net> To: elfring@users.sourceforge.net Cc: samuel@sortiz.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] irda: Delete an unnecessary check before the function call "irlmp_unregister_service" From: David Miller In-Reply-To: <5638EF52.7030300@users.sourceforge.net> References: <5317A59D.4@users.sourceforge.net> <5638EF52.7030300@users.sourceforge.net> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 Nov 2015 10:31:10 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: SF Markus Elfring Date: Tue, 3 Nov 2015 18:30:58 +0100 > From: Markus Elfring > Date: Tue, 3 Nov 2015 18:18:37 +0100 > > The irlmp_unregister_service() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied.