From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932871AbbLHFgL (ORCPT ); Tue, 8 Dec 2015 00:36:11 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:34217 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932264AbbLHFgI (ORCPT ); Tue, 8 Dec 2015 00:36:08 -0500 Date: Tue, 8 Dec 2015 06:36:04 +0100 From: Ingo Molnar To: Peter Zijlstra Cc: vincent.weaver@maine.edu, jolsa@redhat.com, torvalds@linux-foundation.org, eranian@google.com, tglx@linutronix.de, acme@redhat.com, ak@linux.intel.com, linux-kernel@vger.kernel.org, hpa@zytor.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:perf/core] perf/x86: Use INST_RETIRED.PREC_DIST for cycles: ppp Message-ID: <20151208053604.GA15632@gmail.com> References: <1448929689-13771-2-git-send-email-andi@firstfloor.org> <20151206131102.GA12167@gmail.com> <20151207135107.GA6356@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151207135107.GA6356@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra wrote: > On Sun, Dec 06, 2015 at 02:11:02PM +0100, Ingo Molnar wrote: > > > the symptom is that latest 'perf top' and 'perf record' produces no samples. > > > > So I've removed this commit and the related Skylake commit from -tip: > > > > 4576ceaa56a8 perf/x86: Use INST_RETIRED.PREC_DIST for cycles:ppp > > ac1e1d30cf90 perf/x86: Use INST_RETIRED.TOTAL_CYCLES_PS for cycles:pp for Skylake > > > > you need to do better testing next time around. Note: if you resubmit the patches, > > please also pick up the updates commit changelogs from the tip-bot emails, don't > > use your original changelogs. > > OK, so I need: > > lkml.kernel.org/r/1449177740-5422-1-git-send-email-andi@firstfloor.org > lkml.kernel.org/r/1449177740-5422-2-git-send-email-andi@firstfloor.org > > On my IVB because that keeps triggering that case with :ppp, other than > that this seems to work fine on IVB. > > I've also tried on SNB (which does not support the new :ppp thing) and > that too works. > > Sadly I do not have older hardware anymore :/ > > > Also, perf tools DTRT and will use :ppp by default if available. So I checked my NHM box with your latest queue and it now works correctly. Do you have any idea what the difference is/was? Thanks, Ingo