From: Brian Norris <computersforpeace@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Michal Marek <mmarek@suse.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Anton Blanchard <anton@au1.ibm.com>,
Ian Munsie <imunsie@au1.ibm.com>,
Michael Neuling <mikey@neuling.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Olof Johansson <olof@lixom.net>
Subject: Re: Build failure: -Wno-unused-const-variable DNE on old GCC
Date: Thu, 7 Jan 2016 12:18:26 -0800 [thread overview]
Message-ID: <20160107201826.GA120952@google.com> (raw)
In-Reply-To: <1452196651.4028.31.camel@perches.com>
On Thu, Jan 07, 2016 at 11:57:31AM -0800, Joe Perches wrote:
> On Thu, 2016-01-07 at 20:44 +0100, Michal Marek wrote:
> > Dne 7.1.2016 v 20:37 Joe Perches napsal(a):
> > > On Thu, 2016-01-07 at 10:54 -0800, Brian Norris wrote:
> > > > I'm using a GCC 4.6.3 compiler for some compile tests, and I noticed
> > > > that commit 2cd55c68c0a4 ("cxl: Fix build failure due to -Wunused-variable
> > > > behaviour change") breaks my builds, because the
> > > > -Wno-unused-const-variable doesn't exist on GCC 4.6.3.
> > > > drivers/misc/cxl/base.c: At top level:
> > > > cc1: error: unrecognized command line option "-Wno-unused-const-variable" [-Werror]
> > > > Any thoughts on how to best fix this? I'd like not to have to scrounge
> > > > up a new cross compiler just for build tests.
> > > drivers/misc/cxl/Makefile:ccflags-y := -Werror -Wno-unused-const-variable
> > > You could take that -Wno-unused-const-variable out of the
> > > Makefile or maybe add something like:
> > >
> > > $(call cc-ifversion, -ge, 0530, -Wno-unused-const-variable)
> > >
> > > or whatever gcc version actually added that unused-const-variable check
> >
> > We have cc-disable-warning for this.
>
> Thanks Michal.
Cool, thanks! I'll send a patch to use that instead.
> Perhaps most uses of -Werror without some CONFIG_<FOO> guard
> should be removed or replaced by some other mechanism.
+1000. I'd personally like to see all one-off uses of -Werror removed.
> $ git grep -E "=\s*\-Werror" | grep -v CONFIG
> [...]
> arch/alpha/lib/Makefile:ccflags-y := -Werror
> arch/alpha/mm/Makefile:ccflags-y := -Werror
> arch/alpha/oprofile/Makefile:ccflags-y := -Werror -Wno-sign-compare
> arch/metag/oprofile/Makefile:ccflags-y += -Werror
> arch/mips/Kbuild:subdir-ccflags-y := -Werror
^^ I always patch this one out when build-testing MIPS, since I like to
turn up warning levels (e.g., W=1), but not kill the build entirely.
Regards,
Brian
> arch/sh/cchips/hd6446x/Makefile:ccflags-y := -Werror
> arch/sh/kernel/Makefile:ccflags-y := -Werror
> arch/sh/lib/Makefile:ccflags-y := -Werror
> arch/sh/mm/Makefile:ccflags-y := -Werror
> arch/sparc/kernel/Makefile:ccflags-y := -Werror
> arch/sparc/lib/Makefile:ccflags-y := -Werror
> arch/sparc/mm/Makefile:ccflags-y := -Werror
> arch/sparc/prom/Makefile:ccflags := -Werror
> drivers/gpu/drm/tilcdc/Makefile: ccflags-y += -Werror
> drivers/misc/cxl/Makefile:ccflags-y := -Werror -Wno-unused-const-variable
> drivers/scsi/aic7xxx/Makefile:ccflags-y += -Werror
> drivers/scsi/lpfc/Makefile:ccflags-y += -Werror
>
next prev parent reply other threads:[~2016-01-07 20:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 18:54 Build failure: -Wno-unused-const-variable DNE on old GCC Brian Norris
2016-01-07 19:37 ` Joe Perches
2016-01-07 19:44 ` Michal Marek
2016-01-07 19:57 ` Joe Perches
2016-01-07 20:18 ` Brian Norris [this message]
2016-01-07 20:38 ` [PATCH] misc: cxl: fix build for GCC 4.6.x Brian Norris
2016-01-08 2:12 ` Michael Ellerman
2016-01-30 14:20 ` Build failure: -Wno-unused-const-variable DNE on old GCC Maciej W. Rozycki
2016-01-30 17:37 ` Joe Perches
2016-01-07 20:25 ` Arnd Bergmann
2016-01-07 22:51 ` Daniel Axtens
2016-01-07 23:02 ` Brian Norris
2016-01-08 1:31 ` Ian Munsie
2016-01-08 2:07 ` Brian Norris
2016-01-08 2:16 ` Michael Ellerman
2016-01-08 10:14 ` David Laight
2016-01-08 1:33 ` Ian Munsie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107201826.GA120952@google.com \
--to=computersforpeace@gmail.com \
--cc=anton@au1.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mmarek@suse.com \
--cc=mpe@ellerman.id.au \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).