From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Bhumika Goyal <bhumirks@gmail.com>,
jic23@kernel.org, devel@driverdev.osuosl.org,
Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
pmeerw@pmeerw.net
Subject: Re: [PATCH 1/2] staging:iio:adc:added space around '-'
Date: Wed, 20 Jan 2016 17:21:37 +0300 [thread overview]
Message-ID: <20160120142137.GC6370@mwanda> (raw)
In-Reply-To: <56995378.1010204@metafoo.de>
On Fri, Jan 15, 2016 at 09:15:52PM +0100, Lars-Peter Clausen wrote:
> On 01/15/2016 08:42 PM, Bhumika Goyal wrote:
> > This patch adds apace around '-' operator.Found using checkpatch.pl
> >
> > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> > ---
> > drivers/staging/iio/adc/ad7280a.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> > index f45ebed..0c73bce 100644
> > --- a/drivers/staging/iio/adc/ad7280a.c
> > +++ b/drivers/staging/iio/adc/ad7280a.c
> > @@ -744,14 +744,14 @@ out:
> > }
> >
> > static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> > - in_voltage-voltage_thresh_low_value,
> > + in_voltage - voltage_thresh_low_value,
>
> Hi,
>
> Thanks for patch. But when sending cleanup patches like this please make
> sure that you a) understand what the code does and how your change affects
> it and b) as a bare minimum of testing perform a compile test, if possible
> also do functional testing.
>
> The patch as it is, is neither semantically nor syntactically correct. As an
> exercise please make sure you understand why.
Ugh!
It took me a long time to figure out the bug in this patch... Why does
that filename have a mix of dashes and underscores? Too late to fix it
now... :/
regards,
dan carpenter
next prev parent reply other threads:[~2016-01-20 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 19:42 [PATCH 0/2]Staging:iio:adc:add space around '-' Bhumika Goyal
2016-01-15 19:42 ` [PATCH 1/2] staging:iio:adc:added " Bhumika Goyal
2016-01-15 20:15 ` Lars-Peter Clausen
2016-01-20 14:21 ` Dan Carpenter [this message]
2016-01-24 16:36 ` Jonathan Cameron
2016-01-24 17:14 ` Lars-Peter Clausen
2016-01-30 14:12 ` Jonathan Cameron
2016-01-30 15:12 ` Dan Carpenter
2016-01-30 15:15 ` Lars-Peter Clausen
2016-01-30 17:02 ` Joe Perches
2016-01-15 19:42 ` [PATCH 2/2] staging:iio:adc:add " Bhumika Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120142137.GC6370@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Michael.Hennerich@analog.com \
--cc=bhumirks@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).