From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCHSET 00/12] perf tools: Apply percent-limit to callchains
Date: Tue, 26 Jan 2016 13:14:47 +0100 [thread overview]
Message-ID: <20160126121447.GA19017@krava.brq.redhat.com> (raw)
In-Reply-To: <1453643615-1616-1-git-send-email-namhyung@kernel.org>
On Sun, Jan 24, 2016 at 10:53:23PM +0900, Namhyung Kim wrote:
> Hello,
>
> This patchset tries to implement percent limit to callchains which was
> requested by Andi Kleen. For some reason, limiting callchains by
> (overhead) percentage didn't work well. This patch fixes it and make
> --percent-limit also works for callchains as well as hist entries.
>
> This is available on 'perf/callchain-limit-v1' branch in my tree:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
>
> Any comments are welcome,
>
> Thanks,
> Namhyung
>
>
> Namhyung Kim (12):
> perf report: Apply --percent-limit to callchains also
> perf report: Apply callchain percent limit on --stdio
> perf report: Get rid of hist_entry__callchain_fprintf()
> perf report: Fix percent calculation on --stdio
> perf report: Hide output pipe for percent-limited callchains on stdio
> perf hists browser: Fix dump to show correct callchain style
> perf hists browser: Fix callchain_node__count_rows()
> perf hists browser: Apply callchain percent limit
> perf hists browser: Fix callchain counting when press ENTER key
> perf hists browser: Fix counting callchains when expand/collapse all
> perf hists browser: Update percent base for fractal callchain mode
> perf report: Fix callchain percent limit on --gtk
is 0.5 the default or one has to use the --percent-limit 0.5
for the limit to be effective?
without the option I'm getting empty callchains that are below 0.5
but only in TUI mode (attached).. --stdio shows them all unfolded
thanks,
jirka
---
+ 46.69% 46.69% ls [kernel.vmlinux] [k] intel_bts_enable_local ▒
+ 0.08% 0.00% perf [kernel.vmlinux] [k] perf_pmu_enable.part.87 ▒
+ 0.08% 0.00% perf [kernel.vmlinux] [k] perf_event_context_sched_in ▒
+ 0.08% 0.00% perf [kernel.vmlinux] [k] perf_event_exec ▒
+ 0.08% 0.00% perf [kernel.vmlinux] [k] setup_new_exec ▒
+ 0.08% 0.00% perf [kernel.vmlinux] [k] load_elf_binary ▒
+ 0.08% 0.00% perf [kernel.vmlinux] [k] search_binary_handler ▒
+ 0.08% 0.00% perf [kernel.vmlinux] [k] do_execveat_common.isra.33 ▒
+ 0.08% 0.00% perf [kernel.vmlinux] [k] sys_execve ▒
+ 0.08% 0.00% perf [kernel.vmlinux] [k] return_from_execve ▒
- 0.08% 0.00% perf [unknown] [k] 0x00007f2175b35e07 ▒
- 0.04% 0.00% perf [kernel.vmlinux] [k] perf_event_nmi_handler ▒
- 0.04% 0.00% perf [kernel.vmlinux] [k] nmi_handle ▒
- 0.04% 0.00% perf [kernel.vmlinux] [k] default_do_nmi ▒
- 0.04% 0.00% perf [kernel.vmlinux] [k] do_nmi ▒
- 0.04% 0.00% perf [kernel.vmlinux] [k] end_repeat_nmi ▒
- 0.04% 0.04% perf [kernel.vmlinux] [k] x86_pmu_enable ▒
- 0.04% 0.04% perf [kernel.vmlinux] [k] native_apic_mem_write ▒
next prev parent reply other threads:[~2016-01-26 12:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 13:53 [PATCHSET 00/12] perf tools: Apply percent-limit to callchains Namhyung Kim
2016-01-24 13:53 ` [PATCH 01/12] perf report: Apply --percent-limit to callchains also Namhyung Kim
2016-01-24 13:53 ` [PATCH 02/12] perf report: Apply callchain percent limit on --stdio Namhyung Kim
2016-01-24 13:53 ` [PATCH 03/12] perf report: Get rid of hist_entry__callchain_fprintf() Namhyung Kim
2016-01-24 13:53 ` [PATCH 04/12] perf report: Fix percent calculation on --stdio Namhyung Kim
2016-01-24 13:53 ` [PATCH 05/12] perf report: Hide output pipe for percent-limited callchains on stdio Namhyung Kim
2016-01-24 13:53 ` [PATCH 06/12] perf hists browser: Fix dump to show correct callchain style Namhyung Kim
2016-01-24 13:53 ` [PATCH 07/12] perf hists browser: Fix callchain_node__count_rows() Namhyung Kim
2016-01-26 11:46 ` Jiri Olsa
2016-01-26 12:32 ` Namhyung Kim
2016-01-24 13:53 ` [PATCH 08/12] perf hists browser: Apply callchain percent limit Namhyung Kim
2016-01-24 13:53 ` [PATCH 09/12] perf hists browser: Fix callchain counting when press ENTER key Namhyung Kim
2016-01-24 13:53 ` [PATCH 10/12] perf hists browser: Fix counting callchains when expand/collapse all Namhyung Kim
2016-01-24 13:53 ` [PATCH 11/12] perf hists browser: Update percent base for fractal callchain mode Namhyung Kim
2016-01-24 13:53 ` [PATCH 12/12] perf report: Fix callchain percent limit on --gtk Namhyung Kim
2016-01-25 2:16 ` [PATCHSET 00/12] perf tools: Apply percent-limit to callchains Andi Kleen
2016-01-26 12:14 ` Jiri Olsa [this message]
2016-01-26 12:51 ` Namhyung Kim
2016-01-26 13:27 ` Jiri Olsa
2016-01-26 14:10 ` Namhyung Kim
2016-01-26 14:41 ` Jiri Olsa
2016-01-26 14:49 ` Namhyung Kim
2016-01-26 15:18 ` Jiri Olsa
2016-01-26 15:30 ` Arnaldo Carvalho de Melo
2016-01-26 15:41 ` Jiri Olsa
2016-01-26 15:54 ` Namhyung Kim
2016-01-26 16:15 ` Jiri Olsa
2016-01-27 13:21 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126121447.GA19017@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).