linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Pratyush Anand <panand@redhat.com>,
	schwidefsky@de.ibm.com, rostedt@goodmis.org,
	linux-s390@vger.kernel.org, Chunyu Hu <chuhu@redhat.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] s390:ftrace: add save_stack_trace_regs()
Date: Fri, 29 Jan 2016 13:57:49 +0100	[thread overview]
Message-ID: <20160129125749.GD3896@osiris> (raw)
In-Reply-To: <20160129085447.GA3896@osiris>

On Fri, Jan 29, 2016 at 09:54:47AM +0100, Heiko Carstens wrote:
> On Fri, Jan 29, 2016 at 10:50:28AM +0530, Pratyush Anand wrote:
> > Implement save_stack_trace_regs, so that stacktrace of a kprobe events can
> > be obtained.
> > 
> > Without this we see following warning:
> > "save_stack_trace_regs() not implemented yet."
> > when we execute:
> > echo stacktrace > /sys/kernel/debug/tracing/trace_options
> > echo "p kfree" >> /sys/kernel/debug/tracing/kprobe_events
> > echo 1 > /sys/kernel/debug/tracing/events/kprobes/enable
> > 
> > Reported-by: Chunyu Hu <chuhu@redhat.com>
> > Signed-off-by: Pratyush Anand <panand@redhat.com>
> > ---
> 
> Thanks. I just figured out that the ftrace stack tracer doesn't work at all
> anymore on s390.  I will apply your patch after I fixed that. ;)

Surpringly it wasn't one of my own patches which broke the stack tracer on
s390, but one from Steven:

72ac426a5bb0 ("tracing: Clean up stack tracing and fix fentry updates")

Now I only need to figure out why :)

  reply	other threads:[~2016-01-29 12:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29  5:20 [PATCH] s390:ftrace: add save_stack_trace_regs() Pratyush Anand
2016-01-29  8:54 ` Heiko Carstens
2016-01-29 12:57   ` Heiko Carstens [this message]
2016-01-29 13:59     ` Steven Rostedt
2016-01-29 14:45       ` Heiko Carstens
2016-01-29 15:22         ` Steven Rostedt
2016-01-29 16:49           ` Heiko Carstens
2016-01-29 16:56             ` Steven Rostedt
2016-01-29 17:12               ` Heiko Carstens
2016-02-01  9:00 ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160129125749.GD3896@osiris \
    --to=heiko.carstens@de.ibm.com \
    --cc=chuhu@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=panand@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).