From: rcochran@linutronix.de
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
Len Brown <lenb@kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] drivers/idle: make intel_idle.c driver more explicitly non-modular
Date: Tue, 5 Apr 2016 05:11:52 +0200 [thread overview]
Message-ID: <20160405031152.GA22836@linutronix.de> (raw)
In-Reply-To: <20160404195535.GQ1778@windriver.com>
On Mon, Apr 04, 2016 at 03:55:35PM -0400, Paul Gortmaker wrote:
> > This was done in commit 6ce9cd8669fa1195fdc21643370e34523c7ac988
> > ("intel_idle: disable module support") since "...the module capability
> > is cauing more trouble than it is worth."
The reason given in that commit was that "it lost the init race with
ACPI", whatever that means.
> > Since this was done over 5y ago, it is safe to say there is no big desire
> > to overcome the issues with modular versions. So lets remove the modular
> > code that is essentially orphaned, so that when reading the driver there
> > is no doubt it is builtin-only.
So you want to make the driver non-modular due to lack of desire to
fix it?
> This patch will no longer apply since there were several updates to this
> driver by Richard Cochran dated March 29th. Before I go and refresh
> the patch for a v2, is there any objections to the general goal of what
> the patch was aiming to achieve -- avoiding use of modular infrastructure
> in non-modular code, and not having module_exit code that can't be run?
On the one hand, the better way is to fix the issues, keeping the
driver's modular form. That way, by loading and unloading, you can
observe how well it works. I already started by fixing several bugs
WRT module init/exit.
On the other hand, if there is some technical reason why the modular
form is impossible, then the patch should state it.
Thanks,
Richard
next prev parent reply other threads:[~2016-04-05 3:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 17:29 [PATCH] drivers/idle: make intel_idle.c driver more explicitly non-modular Paul Gortmaker
2016-04-04 19:55 ` Paul Gortmaker
2016-04-05 3:11 ` rcochran [this message]
2016-04-05 4:20 ` Brown, Len
2016-04-05 4:30 ` rcochran
2016-04-05 5:53 ` Brown, Len
2016-04-05 7:33 ` rcochran
2016-04-07 16:53 ` Daniel Lezcano
2016-04-20 15:25 ` [PATCH v2] " Paul Gortmaker
2016-04-20 18:13 ` Daniel Lezcano
2016-04-21 3:12 ` Paul Gortmaker
2016-04-21 8:04 ` Daniel Lezcano
2016-04-21 12:44 ` Paul Gortmaker
2016-04-21 13:21 ` Daniel Lezcano
2016-04-21 17:42 ` Paul Gortmaker
2016-06-16 5:00 ` Len Brown
2016-04-05 18:22 ` [PATCH] " Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405031152.GA22836@linutronix.de \
--to=rcochran@linutronix.de \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).