From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: linux-next: Tree for Apr 4
Date: Wed, 13 Apr 2016 09:52:35 +0200 [thread overview]
Message-ID: <20160413075235.GB3832@osiris> (raw)
In-Reply-To: <20160412183408.248092c7@mschwide>
On Tue, Apr 12, 2016 at 06:34:08PM +0200, Martin Schwidefsky wrote:
> On Mon, 4 Apr 2016 16:26:35 +0200
> Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
>
> > On Mon, Apr 04, 2016 at 05:51:09PM +0530, Sudip Mukherjee wrote:
> > > On Monday 04 April 2016 09:39 AM, Stephen Rothwell wrote:
> > > >Hi all,
> > > >
> > > >Changes since 20160401:
> > >
> > > s390 allmodconfig build fails with the error:
> > >
> > > arch/s390/crypto/ghash_s390.c:14:24: fatal error: crypt_s390.h: No
> > > such file or directory
> > > #include "crypt_s390.h"
> > > ^
> > >
> > > build log is at:
> > > https://travis-ci.org/sudipm-mukherjee/parport/jobs/120536718
> > >
> > > caused by the commit -
> > > ce69a690149c ("s390/crypto: cleanup and move the header with the
> > > cpacf definitions") which removed the file "crypt_s390.h"
> >
> > Thanks for letting us know!
> >
> > I just removed that specific patch from the 'features' branch again. It was
> > incomplete since it didn't convert the ghash module at all.
> >
> > No idea what Martin was thinking when pushing that patch.
>
> That is strange. On my local features branch that I use to push to kerne.org
> there is no ghash commit. The last commit is this:
Nobody said there is a ghash commit ;)
> commit ce69a690149c7431d05b4679409ab8fa6ad3a09f
> Author: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Date: Thu Mar 17 15:22:12 2016 +0100
>
> s390/crypto: cleanup and move the header with the cpacf definitions
>
> which Heiko now removed. My guest right now is that the ghash commit stems
> from another tree merged into linux-next and we simply have an unresolved
> dependency here. I do have an updated ghash patch that includes the correct
> header.
Your patch did not convert/touch arch/s390/crypto/ghash_s390.c which is
very old code. And you need to do more within that file than just changing
the include.
next prev parent reply other threads:[~2016-04-13 7:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 4:09 linux-next: Tree for Apr 4 Stephen Rothwell
2016-04-04 12:21 ` Sudip Mukherjee
2016-04-04 14:26 ` Heiko Carstens
2016-04-12 16:34 ` Martin Schwidefsky
2016-04-13 7:52 ` Heiko Carstens [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-04 2:44 Stephen Rothwell
2023-04-04 5:46 Stephen Rothwell
2022-04-04 3:10 Stephen Rothwell
2020-04-04 5:05 Stephen Rothwell
2019-04-04 5:25 Stephen Rothwell
2018-04-04 6:55 Stephen Rothwell
2017-04-04 7:58 Stephen Rothwell
2013-04-04 7:22 Stephen Rothwell
2012-04-04 4:02 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413075235.GB3832@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).