From: David Miller <davem@davemloft.net>
To: jasowang@redhat.com
Cc: mst@redhat.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/2] vhost_net: stop polling socket during rx processing
Date: Tue, 07 Jun 2016 14:46:33 -0700 (PDT) [thread overview]
Message-ID: <20160607.144633.1372446059350476794.davem@davemloft.net> (raw)
In-Reply-To: <1464760594-30326-2-git-send-email-jasowang@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Wed, 1 Jun 2016 01:56:33 -0400
> We don't stop rx polling socket during rx processing, this will lead
> unnecessary wakeups from under layer net devices (E.g
> sock_def_readable() form tun). Rx will be slowed down in this
> way. This patch avoids this by stop polling socket during rx
> processing. A small drawback is that this introduces some overheads in
> light load case because of the extra start/stop polling, but single
> netperf TCP_RR does not notice any change. In a super heavy load case,
> e.g using pktgen to inject packet to guest, we get about ~8.8%
> improvement on pps:
>
> before: ~1240000 pkt/s
> after: ~1350000 pkt/s
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Applied.
next prev parent reply other threads:[~2016-06-07 21:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 5:56 [PATCH V3 0/2] vhost_net polling optimization Jason Wang
2016-06-01 5:56 ` [PATCH V3 1/2] vhost_net: stop polling socket during rx processing Jason Wang
2016-06-07 12:23 ` Michael S. Tsirkin
2016-06-07 21:46 ` David Miller [this message]
2016-06-01 5:56 ` [PATCH V3 2/2] vhost_net: conditionally enable tx polling Jason Wang
2016-06-07 12:26 ` Michael S. Tsirkin
2016-06-08 6:48 ` Jason Wang
2016-06-02 19:08 ` [PATCH V3 0/2] vhost_net polling optimization David Miller
2016-06-03 13:03 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607.144633.1372446059350476794.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).