From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Hemant Kumar <hemant@linux.vnet.ibm.com>,
Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
Brendan Gregg <brendan.d.gregg@gmail.com>
Subject: Re: [PATCH perf/core v10 09/23] perf probe: Show all cached probes
Date: Thu, 9 Jun 2016 11:22:55 -0300 [thread overview]
Message-ID: <20160609142255.GP11589@kernel.org> (raw)
In-Reply-To: <20160608093030.3116.74450.stgit@devbox>
Em Wed, Jun 08, 2016 at 06:30:30PM +0900, Masami Hiramatsu escreveu:
> +char *build_id_cache__origname(const char *sbuild_id)
> +{
> + char *linkname;
> + char buf[PATH_MAX];
> + char *ret = NULL, *p;
> + size_t offs = 5; /* == strlen("../..") */
> +
> + linkname = build_id_cache__linkname(sbuild_id, NULL, 0);
> + if (!linkname)
> + return NULL;
> +
> + if (readlink(linkname, buf, PATH_MAX) < 0)
> + goto out;
> + /* The link should be "../..<origpath>/<sbuild_id>" */
> + p = strrchr(buf, '/'); /* Cut off the "/<sbuild_id>" */
> + if (p && (p > buf + offs)) {
> + *p = '\0';
> + if (buf[offs + 1] == '[')
> + offs++; /*
> + * This is a DSO name, like [kernel.kallsyms].
> + * Skip the first '/', since this is not the
> + * cache of a regular file.
> + */
> + ret = strdup(buf + offs); /* Skip "../..[/]" */
strdup can fail.
> + }
> +out:
> + free(linkname);
> + return ret;
> +}
> +
> static const char *build_id_cache__basename(bool is_kallsyms, bool is_vdso)
> {
> return is_kallsyms ? "kallsyms" : (is_vdso ? "vdso" : "elf");
> @@ -390,6 +419,59 @@ void disable_buildid_cache(void)
> no_buildid_cache = true;
> }
>
> +int build_id_cache__list_all(struct strlist **result)
> +{
> + struct strlist *toplist, *list, *bidlist;
> + struct str_node *nd, *nd2;
> + char *topdir, *linkdir;
> + char sbuild_id[SBUILD_ID_SIZE];
> + int ret = 0;
> +
> + /* Open the top-level directory */
> + if (asprintf(&topdir, "%s/.build-id/", buildid_dir) < 0)
> + return -errno;
Wouldn't be better to just return -1 and leave the caller to look at
errno? I know that there is code that does that, but better stick to the
errno convention?
> + toplist = lsdir(topdir, lsdir_no_dot_filter);
> + if (!toplist) {
> + pr_debug("Failed to opendir %s\n", topdir);
> + ret = -errno;
ditto
> + goto out;
> + }
> + bidlist = strlist__new(NULL, NULL);
> + strlist__for_each(nd, toplist) {
> + if (asprintf(&linkdir, "%s/%s", topdir, nd->s) < 0) {
> + ret = -errno;
> + goto out;
> + }
> + /* Open the lower-level directory */
> + list = lsdir(linkdir, lsdir_no_dot_filter);
> + if (!list) {
> + pr_debug("Failed to open %s: %d\n", linkdir, -errno);
> + goto next;
> + }
> + strlist__for_each(nd2, list) {
> + ret = snprintf(sbuild_id, SBUILD_ID_SIZE, "%s%s",
> + nd->s, nd2->s);
> + if (ret != SBUILD_ID_SIZE - 1) {
> + pr_debug("%s/%s is not buildid cache\n",
> + nd->s, nd2->s);
> + continue;
> + }
> + strlist__add(bidlist, sbuild_id);
strlist__add() can fail, please check its result.
> + }
> + strlist__delete(list);
> +next:
> + free(linkdir);
> + }
> +
> + *result = bidlist;
> +out:
> + if (toplist)
> + strlist__delete(toplist);
No need for checking toplist.
> + free(topdir);
> +
> + return ret;
> +}
<SNIP>
- Arnaldo
next prev parent reply other threads:[~2016-06-09 14:23 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 9:29 [PATCH perf/core v10 00/23] perf-probe --cache and SDT support Masami Hiramatsu
2016-06-08 9:29 ` [PATCH perf/core v10 01/23] perf: util: Fix rm_rf() to handle non-regular files correctly Masami Hiramatsu
2016-06-16 8:31 ` [tip:perf/core] perf tools: " tip-bot for Masami Hiramatsu
2016-06-08 9:29 ` [PATCH perf/core v10 02/23] perf-probe: Fix to add NULL check for strndup Masami Hiramatsu
2016-06-16 8:32 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2016-06-08 9:29 ` [PATCH perf/core v10 03/23] perf-buildid: Rename and export build_id_cache__cachedir() Masami Hiramatsu
2016-06-16 8:32 ` [tip:perf/core] perf buildid: " tip-bot for Masami Hiramatsu
2016-06-08 9:29 ` [PATCH perf/core v10 04/23] perf probe: Add perf_probe_event__copy() Masami Hiramatsu
2016-06-16 8:33 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2016-06-08 9:29 ` [PATCH perf/core v10 05/23] perf probe: Recover and export synthesize_perf_probe_point() Masami Hiramatsu
2016-06-16 8:33 ` [tip:perf/core] perf probe: Uncomment " tip-bot for Masami Hiramatsu
2016-06-08 9:29 ` [PATCH perf/core v10 06/23] perf probe-file: Introduce perf_cache interfaces Masami Hiramatsu
2016-06-09 14:16 ` Arnaldo Carvalho de Melo
2016-06-10 22:18 ` Masami Hiramatsu
2016-06-08 9:30 ` [PATCH perf/core v10 07/23] perf probe: Add --cache option to cache the probe definitions Masami Hiramatsu
2016-06-09 14:18 ` Arnaldo Carvalho de Melo
2016-06-10 23:32 ` Masami Hiramatsu
2016-06-08 9:30 ` [PATCH perf/core v10 08/23] perf probe: Use cache entry if possible Masami Hiramatsu
2016-06-08 9:30 ` [PATCH perf/core v10 09/23] perf probe: Show all cached probes Masami Hiramatsu
2016-06-09 14:22 ` Arnaldo Carvalho de Melo [this message]
2016-06-11 0:28 ` Masami Hiramatsu
2016-06-12 3:20 ` Masami Hiramatsu
2016-06-08 9:30 ` [PATCH perf/core v10 10/23] perf probe: Remove caches when --cache is given Masami Hiramatsu
2016-06-09 14:28 ` Arnaldo Carvalho de Melo
2016-06-11 1:17 ` Masami Hiramatsu
2016-06-08 9:30 ` [PATCH perf/core v10 11/23] perf/sdt: ELF support for SDT Masami Hiramatsu
2016-06-08 9:31 ` [PATCH perf/core v10 12/23] perf probe: Add group name support Masami Hiramatsu
2016-06-08 9:31 ` [PATCH perf/core v10 13/23] perf buildid-cache: Scan and import user SDT events to probe cache Masami Hiramatsu
2016-06-08 9:31 ` [PATCH perf/core v10 14/23] perf probe: Accept %sdt and %cached event name Masami Hiramatsu
2016-06-08 9:31 ` [PATCH perf/core v10 15/23] perf-list: Show SDT and pre-cached events Masami Hiramatsu
2016-06-08 9:31 ` [PATCH perf/core v10 16/23] perf-list: Skip SDTs placed in invalid binaries Masami Hiramatsu
2016-06-08 9:31 ` [PATCH perf/core v10 17/23] perf: probe-cache: Add for_each_probe_cache_entry() wrapper Masami Hiramatsu
2016-06-08 9:31 ` [PATCH perf/core v10 18/23] perf probe: Allow wildcard for cached events Masami Hiramatsu
2016-06-08 9:32 ` [PATCH perf/core v10 19/23] perf probe: Search SDT/cached event from all probe caches Masami Hiramatsu
2016-06-08 9:32 ` [PATCH perf/core v10 20/23] perf probe: Support @BUILDID or @FILE suffix for SDT events Masami Hiramatsu
2016-06-08 9:32 ` [PATCH perf/core v10 21/23] perf probe: Support a special SDT probe format Masami Hiramatsu
2016-06-08 9:32 ` [PATCH perf/core v10 22/23] perf build: Add sdt feature detection Masami Hiramatsu
2016-06-08 9:32 ` [PATCH perf/core v10 23/23] perf-test: Add a test case for SDT event Masami Hiramatsu
2016-06-08 11:13 ` [PATCH perf/core v10 00/23] perf-probe --cache and SDT support Masami Hiramatsu
2016-06-08 11:15 ` [PATCH perf/core v10 22/23] perf build: Add sdt feature detection Masami Hiramatsu
2016-06-08 11:16 ` [PATCH perf/core v10 23/23] perf-test: Add a test case for SDT event Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609142255.GP11589@kernel.org \
--to=acme@kernel.org \
--cc=ananth@linux.vnet.ibm.com \
--cc=brendan.d.gregg@gmail.com \
--cc=hemant@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).