Re: [PATCH v2 2/2] PCI: Rockchip: Add Rockchip PCIe controller support

From: kbuild test robot <lkp@intel.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: kbuild-all@01.org, Bjorn Helgaas <bhelgaas@google.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	linux-pci@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	Heiko Stuebner <heiko@sntech.de>,
	Doug Anderson <dianders@chromium.org>,
	Wenrui Li <wenrui.li@rock-chips.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, Shawn Lin <shawn.lin@rock-chips.com>
Subject: Re: [PATCH v2 2/2] PCI: Rockchip: Add Rockchip PCIe controller support
Date: Fri, 10 Jun 2016 09:35:18 +0800	[thread overview]
Message-ID: <201606100921.7sm7HA6o%fengguang.wu@intel.com> (raw)
In-Reply-To: <1465373154-882-1-git-send-email-shawn.lin@rock-chips.com>

[-- Attachment #1: Type: text/plain, Size: 1959 bytes --]

Hi,

[auto build test WARNING on pci/next]
[also build test WARNING on v4.7-rc2 next-20160609]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Shawn-Lin/Documentation-bindings-add-dt-doc-for-Rockchip-PCIe-controller/20160608-161005
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/pci/host/pcie-rockchip.c: In function 'rockchip_pcie_probe':
>> drivers/pci/host/pcie-rockchip.c:876:5: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]
     if (err)
        ^

vim +/err +876 drivers/pci/host/pcie-rockchip.c

   860		int reg_no;
   861		int err = 0;
   862		int offset = 0;
   863	
   864		LIST_HEAD(res);
   865	
   866		if (!dev->of_node)
   867			return -ENODEV;
   868	
   869		port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);
   870		if (!port)
   871			return -ENOMEM;
   872	
   873		port->dev = dev;
   874	
   875		err = rockchip_pcie_parse_dt(port);
 > 876		if (err)
   877			return err;
   878	
   879		err = clk_prepare_enable(port->aclk_pcie);
   880		if (err) {
   881			dev_err(dev, "Unable to enable aclk_pcie clock.\n");
   882			goto err_aclk_pcie;
   883		}
   884	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 50198 bytes --]