On Fri, Jun 10, 2016 at 07:18:44PM +0100, Srinivas Kandagatla wrote: > +Codec IP is divided into two parts, first analog which is integrated in pmic pm8916 > +and secondly digital part which is integrated into application processor. Codec register > +controls are also split across pmic an lpass. Analog part is controlled via spmi bus to pmic. Please keep things wrapped at less than 80 columns. > + - interrupt-parent : The parent interrupt controller. > + - interrupts: List of interrupts in given SPMI peripheral. > + - interrupt-names: Names specified to above list of interrupts in same > + order. List of supported interrupt names are: > + "spk_cnp_int" - Speaker click and pop interrupt Please format this more clearly so these don't look like properties, more indentation would be good. > + - vddio-supply: phandle to VDD_CDC_IO regulator device tree node. > + - vdd-tx-rx-supply: phandle to VDD_CDC_TX/RX/CX regulator device tree node. You should name the supplies with the same name as the datasheet uses.