From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752827AbcFNQkt (ORCPT ); Tue, 14 Jun 2016 12:40:49 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44012 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796AbcFNQk2 (ORCPT ); Tue, 14 Jun 2016 12:40:28 -0400 Date: Tue, 14 Jun 2016 09:40:17 -0700 From: Greg KH To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: David Miller , andrew@lunn.ch, mario_limonciello@dell.com, hayeswang@realtek.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, anthony.wong@canonical.com Subject: Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD Message-ID: <20160614164017.GB14477@kroah.com> References: <1465323757-7249-1-git-send-email-mario_limonciello@dell.com> <20160611153921.GP2338@lunn.ch> <20160611.104226.1571085838142610714.davem@davemloft.net> <201606141828.10969@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201606141828.10969@pali> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 14, 2016 at 06:28:10PM +0200, Pali Rohár wrote: > On Saturday 11 June 2016 19:42:26 David Miller wrote: > > From: Andrew Lunn > > Date: Sat, 11 Jun 2016 17:39:21 +0200 > > > > > What is still open is do we want to accept it at all? Do we accept > > > the concept of putting the same MAC address on multiple interfaces > > > at hotplug time? Do we trust BIOS vendors to not keep changing > > > DSDT property name, since it is not standardised? > > > > > > Do we want this at all should be decided by somebody more senior > > > then those passing comments on the code. > > > > Indeed, I think the behavior of using the same MAC address on > > multiple interfaces if we plug several of these in at once is not > > good. > > > > We shouldn't behave this way just because the Microsoft driver does. > > I agree, but in some cases it is night mare for local admins when > booting different OS cause changing MAC address on local network. > > Another similar situation: Imagine that you have two USB network cards > and both have "burned" into their registers same MAC address. If you > connect both those USB network cards, linux kernel bind appropriate > driver which read MAC address for both those cards. But those addresses > are same. What will linux kernel do in this case? If you can find such a broken USB device, try it and see :) (hint, might be hard to find, I've never seen such a device before.) I don't see how that pertains to this issue, sorry, how does broken USB hardware compare to a working Dell device? thanks, greg k-h