From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753512AbcFOPuR (ORCPT ); Wed, 15 Jun 2016 11:50:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:39803 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932700AbcFOPpJ (ORCPT ); Wed, 15 Jun 2016 11:45:09 -0400 Date: Wed, 15 Jun 2016 17:45:07 +0200 From: "Luis R. Rodriguez" To: Julia Lawall Cc: "Luis R. Rodriguez" , Gilles Muller , nicolas.palix@imag.fr, mmarek@suse.com, linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr Subject: Re: [PATCH 4/4] scripts/coccinelle: require coccinelle >= 1.0.4 on device_node_continue.cocci Message-ID: <20160615154507.GM11948@wotan.suse.de> References: <1465942217-14452-1-git-send-email-mcgrof@kernel.org> <1465942217-14452-5-git-send-email-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2016 at 08:08:41AM +0200, Julia Lawall wrote: > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > Make use of the new kernel python requirements library to be able to > > specify coccinelle binary version requirements. The cocci file > > device_node_continue.cocci requires at least coccinelle 1.0.4. > > > > Signed-off-by: Luis R. Rodriguez > > --- > > scripts/coccinelle/iterators/device_node_continue.cocci | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/scripts/coccinelle/iterators/device_node_continue.cocci b/scripts/coccinelle/iterators/device_node_continue.cocci > > index 38ab744a4037..b590de9418d1 100644 > > --- a/scripts/coccinelle/iterators/device_node_continue.cocci > > +++ b/scripts/coccinelle/iterators/device_node_continue.cocci > > @@ -12,6 +12,19 @@ virtual context > > virtual org > > virtual report > > > > +// This uses a conjunction, which requires at least coccinelle >= 1.0.4 > > +@script:python@ > > +@@ > > + > > +import sys > > +from lib import reqs > > + > > +req = reqs.Req() > > +req.coccinelle('1.0.4') > > +if not req.reqs_match(): > > + cocci.exit() > > + sys.exit(1) > > This doesn't look very appealing to me. Shouldn't Coccinelle handle this > itself? Oh I agree, however what options do we have at the moment instead of an odd parse error complaint ? This lets one annotate version requirements and is backward compatible. Luis