From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754123AbcFPK3L (ORCPT ); Thu, 16 Jun 2016 06:29:11 -0400 Received: from outbound-smtp05.blacknight.com ([81.17.249.38]:56126 "EHLO outbound-smtp05.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070AbcFPK3I (ORCPT ); Thu, 16 Jun 2016 06:29:08 -0400 Date: Thu, 16 Jun 2016 11:29:04 +0100 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , Linux-MM , Rik van Riel , Johannes Weiner , LKML Subject: Re: [PATCH 10/27] mm, vmscan: Clear congestion, dirty and need for compaction on a per-node basis Message-ID: <20160616102904.GH1868@techsingularity.net> References: <1465495483-11855-1-git-send-email-mgorman@techsingularity.net> <1465495483-11855-11-git-send-email-mgorman@techsingularity.net> <510d374a-074e-cd32-bdbe-61754052b21b@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <510d374a-074e-cd32-bdbe-61754052b21b@suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2016 at 11:29:00AM +0200, Vlastimil Babka wrote: > On 06/09/2016 08:04 PM, Mel Gorman wrote: > >Congested and dirty tracking of a node and whether reclaim should stall > >is still based on zone activity. This patch considers whether the kernel > >should stall based on node-based reclaim activity. > > I'm a bit confused about the description vs actual code. > It appears to move some duplicated code to a related function, which is > fine. The rest of callsites that didn't perform the clearing before > (prepare_kswapd_sleep() and wakeup_kswapd()) might be a bit overkill, but > won't hurt. But I don't see the part "considers whether the kernel > should stall based on node-based reclaim activity". Is something missing? > Tired when writing the changelog. Does this make more sense? mm, vmscan: Remove duplicate logic clearing node congestion and dirty state Reclaim may stall if there is too much dirty or congested data on a node. This was previously based on zone flags and the logic for clearing the flags is in two places. As congestion/dirty tracking is now tracked on a per-node basis, we can remove some duplicate logic. -- Mel Gorman SUSE Labs