From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754476AbcFPQE6 (ORCPT ); Thu, 16 Jun 2016 12:04:58 -0400 Received: from outbound-smtp07.blacknight.com ([46.22.139.12]:33282 "EHLO outbound-smtp07.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754376AbcFPQE5 (ORCPT ); Thu, 16 Jun 2016 12:04:57 -0400 Date: Thu, 16 Jun 2016 17:04:48 +0100 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , Linux-MM , Rik van Riel , Johannes Weiner , LKML Subject: Re: [PATCH 16/27] mm: Move page mapped accounting to the node Message-ID: <20160616160448.GL1868@techsingularity.net> References: <1465495483-11855-1-git-send-email-mgorman@techsingularity.net> <1465495483-11855-17-git-send-email-mgorman@techsingularity.net> <5c8812fc-f2d3-3008-74ba-9072ae8c7cb3@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <5c8812fc-f2d3-3008-74ba-9072ae8c7cb3@suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2016 at 05:52:59PM +0200, Vlastimil Babka wrote: > On 06/09/2016 08:04 PM, Mel Gorman wrote: > >Reclaim makes decisions based on the number of file pages that are mapped but > >it's mixing node and zone information. Account NR_FILE_MAPPED pages on the node. > > And NR_ANON_PAGES. > Yes. > >Signed-off-by: Mel Gorman > > Acked-by: Vlastimil Babka > > I've noticed some new "page_zone(page)->zone_pgdat" instances here. > FWIW, I created a page_pgdat helper and converted all patterns like this introduced by the series to the helper. There are other potential users of the helper in the tree that are not touched by the patches but I left them to preserve history. -- Mel Gorman SUSE Labs