From: "Pali Rohár" <pali.rohar@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
sakari.ailus@iki.fi, sre@kernel.org, linux-media@vger.kernel.org,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
mchehab@osg.samsung.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor
Date: Sat, 18 Jun 2016 17:37:33 +0200 [thread overview]
Message-ID: <201606181737.33116@pali> (raw)
In-Reply-To: <20160618152259.GC8392@amd>
[-- Attachment #1: Type: Text/Plain, Size: 2345 bytes --]
On Saturday 18 June 2016 17:22:59 Pavel Machek wrote:
> > +/*
> > + *
> > + * Stingray sensor mode settings for Scooby
> > + *
> > + *
> > + */
>
> I'd fix it to normal comment style... and possibly remove it. Can you
> understand what it says?
>
> > + },
> > + .regs = {
> > + { ET8EK8_REG_8BIT, 0x1239, 0x4F }, /* */
> > + { ET8EK8_REG_8BIT, 0x1238, 0x02 }, /* */
> > + { ET8EK8_REG_8BIT, 0x123B, 0x70 }, /* */
> > + { ET8EK8_REG_8BIT, 0x123A, 0x05 }, /* */
> > + { ET8EK8_REG_8BIT, 0x121B, 0x63 }, /* */
> > + { ET8EK8_REG_8BIT, 0x1220, 0x85 }, /* */
> > + { ET8EK8_REG_8BIT, 0x1221, 0x00 }, /* */
> > + { ET8EK8_REG_8BIT, 0x1222, 0x58 }, /* */
> > + { ET8EK8_REG_8BIT, 0x1223, 0x00 }, /* */
> > + { ET8EK8_REG_8BIT, 0x121D, 0x63 }, /* */
> > + { ET8EK8_REG_8BIT, 0x125D, 0x83 }, /* */
> > + { ET8EK8_REG_TERM, 0, 0}
> > + }
>
> I'd remove the empty comments...
>
> > +struct et8ek8_meta_reglist meta_reglist = {
> > + .version = "V14 03-June-2008",
>
> Do we need the version?
>
> > + .reglist = {
> > + { .ptr = &mode1_poweron_mode2_16vga_2592x1968_12_07fps },
> > + { .ptr = &mode1_16vga_2592x1968_13_12fps_dpcm10_8 },
> > + { .ptr = &mode3_4vga_1296x984_29_99fps_dpcm10_8 },
> > + { .ptr = &mode4_svga_864x656_29_88fps },
> > + { .ptr = &mode5_vga_648x492_29_93fps },
> > + { .ptr = &mode2_16vga_2592x1968_3_99fps },
> > + { .ptr = &mode_648x492_5fps },
> > + { .ptr = &mode3_4vga_1296x984_5fps },
> > + { .ptr = &mode_4vga_1296x984_25fps_dpcm10_8 },
> > + { .ptr = 0 }
> > + }
> > +};
>
> I'd say .ptr = NULL.
>
Anyway, this code was generated from configuration ini files and perl
script available from: https://gitorious.org/omap3camera/camera-firmware
Originally in Maemo above C structure is compiled into binary file and
via request_firmware() loaded from userspace to kernel driver.
For me this sounds like a big overkill, so I included above reglist code
direcly into et8ek8 kernel driver to avoid request_firmware() and
separate userspace storage...
And for smia-sensor (front webcam) in that gitorious repository is also
reglist structure. It is not needed? Can somebody investigate why it is
not needed?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2016-06-18 15:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 15:39 [PATCH v3 0/2] media: add et8ek8 camera sensor driver and documentation Ivaylo Dimitrov
2016-06-11 15:39 ` [PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor Ivaylo Dimitrov
2016-06-18 15:22 ` Pavel Machek
2016-06-18 15:37 ` Pali Rohár [this message]
2016-06-18 16:04 ` Pavel Machek
2016-06-18 16:11 ` Pali Rohár
2016-06-20 21:59 ` Sakari Ailus
2016-06-11 15:39 ` [PATCH v3 2/2] media: et8ek8: Add documentation Ivaylo Dimitrov
2016-06-14 22:05 ` Rob Herring
2016-06-15 4:31 ` Sakari Ailus
2016-06-15 18:41 ` Rob Herring
2016-06-15 19:24 ` Ivaylo Dimitrov
2016-06-18 14:36 ` Pavel Machek
2016-10-23 7:33 ` [PATCH v3 0/2] media: add et8ek8 camera sensor driver and documentation Pavel Machek
2016-10-23 10:22 ` v4.9-rc1: smiapp divides by zero Pavel Machek
2016-10-23 10:32 ` Pali Rohár
2016-10-23 10:52 ` Pavel Machek
2016-10-23 14:09 ` Sakari Ailus
2016-10-23 18:33 ` Pavel Machek
2016-10-23 18:05 ` [PATCH v3 0/2] media: add et8ek8 camera sensor driver and documentation Ivaylo Dimitrov
2016-10-23 18:17 ` Pavel Machek
2016-10-23 18:36 ` Ivaylo Dimitrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201606181737.33116@pali \
--to=pali.rohar@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=pavel@ucw.cz \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).