From: David Miller <davem@davemloft.net>
To: qiang.zhao@nxp.com
Cc: oss@buserror.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, xiaobo.xie@nxp.com
Subject: Re: [PATCH] Maxim/driver: Add driver for maxim ds26522
Date: Fri, 24 Jun 2016 15:46:08 -0400 (EDT) [thread overview]
Message-ID: <20160624.154608.48260039018744249.davem@davemloft.net> (raw)
In-Reply-To: <AM3PR04MB11854F945F63BFF95C74AE94912E0@AM3PR04MB1185.eurprd04.prod.outlook.com>
From: Qiang Zhao <qiang.zhao@nxp.com>
Date: Fri, 24 Jun 2016 02:00:33 +0000
> On Thu, 2016-06-23 at 10:59PM, David Miller wrote:
>> -----Original Message-----
>> From: David Miller [mailto:davem@davemloft.net]
>> Sent: Thursday, June 23, 2016 10:59 PM
>> To: Qiang Zhao <qiang.zhao@nxp.com>
>> Cc: oss@buserror.net; linux-kernel@vger.kernel.org; netdev@vger.kernel.org;
>> Xiaobo Xie <xiaobo.xie@nxp.com>
>> Subject: Re: [PATCH] Maxim/driver: Add driver for maxim ds26522
>>
>> From: Zhao Qiang <qiang.zhao@nxp.com>
>> Date: Thu, 23 Jun 2016 09:09:45 +0800
>>
>> > +MODULE_DESCRIPTION(DRV_DESC);
>>
>> There is no definition of DRV_DESC, so this makes it look like you didn't even
>> compile this driver.
>
> I really, really compiled this driver.
> Thank you for your review and comments. I will modify it the next version.
>
> [zhaoqiang@titan:~/upstream/linux]$ll drivers/net/wan/slic_ds26522.o
> -rw-r--r-- 1 zhaoqiang klocwork 153288 Jun 22 15:48 drivers/net/wan/slic_ds26522.o
> [zhaoqiang@titan:~/upstream/linux]$date
Obviously with the driver not configured as a module, and thus explicitly
not testing the failing statement at all.
prev parent reply other threads:[~2016-06-24 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 1:09 [PATCH] Maxim/driver: Add driver for maxim ds26522 Zhao Qiang
2016-06-23 3:34 ` kbuild test robot
2016-06-23 14:59 ` David Miller
2016-06-24 2:00 ` Qiang Zhao
2016-06-24 19:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624.154608.48260039018744249.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss@buserror.net \
--cc=qiang.zhao@nxp.com \
--cc=xiaobo.xie@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).