From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, hch@infradead.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v6 44/46] remoteproc: qcom: Use unsigned long for dma_attrs
Date: Wed, 13 Jul 2016 09:51:31 -0700 [thread overview]
Message-ID: <20160713165131.GK23833@tuxbot> (raw)
In-Reply-To: <1468399300-5399-44-git-send-email-k.kozlowski@samsung.com>
On Wed 13 Jul 01:41 PDT 2016, Krzysztof Kozlowski wrote:
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
>
> Changes since v5:
> New patch.
> ---
> drivers/remoteproc/qcom_q6v5_pil.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c
> index fb4c56cc6dfc..4913ec6f9d00 100644
> --- a/drivers/remoteproc/qcom_q6v5_pil.c
> +++ b/drivers/remoteproc/qcom_q6v5_pil.c
> @@ -349,13 +349,12 @@ static void q6v5proc_halt_axi_port(struct q6v5 *qproc,
>
> static int q6v5_mpss_init_image(struct q6v5 *qproc, const struct firmware *fw)
> {
> - DEFINE_DMA_ATTRS(attrs);
> + unsigned long dma_attrs = DMA_ATTR_FORCE_CONTIGUOUS;
> dma_addr_t phys;
> void *ptr;
> int ret;
>
> - dma_set_attr(DMA_ATTR_FORCE_CONTIGUOUS, &attrs);
> - ptr = dma_alloc_attrs(qproc->dev, fw->size, &phys, GFP_KERNEL, &attrs);
> + ptr = dma_alloc_attrs(qproc->dev, fw->size, &phys, GFP_KERNEL, dma_attrs);
> if (!ptr) {
> dev_err(qproc->dev, "failed to allocate mdt buffer\n");
> return -ENOMEM;
> @@ -372,7 +371,7 @@ static int q6v5_mpss_init_image(struct q6v5 *qproc, const struct firmware *fw)
> else if (ret < 0)
> dev_err(qproc->dev, "MPSS header authentication failed: %d\n", ret);
>
> - dma_free_attrs(qproc->dev, fw->size, ptr, phys, &attrs);
> + dma_free_attrs(qproc->dev, fw->size, ptr, phys, dma_attrs);
>
> return ret < 0 ? ret : 0;
> }
> --
> 1.9.1
>
next prev parent reply other threads:[~2016-07-13 16:52 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 8:39 [PATCH v6 00/46] dma-mapping: Use unsigned long for dma_attrs Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 01/46] [media] mtk-vcodec: Remove unused dma_attrs Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 02/46] dma-mapping: Use unsigned long for dma_attrs Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 03/46] alpha: " Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 04/46] arc: " Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 05/46] ARM: " Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 06/46] arm64: " Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 07/46] avr32: " Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 08/46] blackfin: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 09/46] c6x: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 10/46] cris: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 11/46] frv: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 12/46] drm/exynos: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 13/46] drm/mediatek: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 14/46] drm/msm: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 15/46] drm/nouveau: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 16/46] drm/rockship: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 17/46] infiniband: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 18/46] iommu: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 19/46] [media] " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 20/46] xen: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 21/46] swiotlb: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 22/46] powerpc: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 23/46] video: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 24/46] x86: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 25/46] iommu: intel: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 26/46] h8300: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 27/46] hexagon: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 28/46] ia64: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 29/46] m68k: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 30/46] metag: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 31/46] microblaze: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 32/46] mips: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 33/46] mn10300: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 34/46] nios2: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 35/46] openrisc: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 36/46] parisc: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 37/46] misc: mic: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 38/46] s390: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 39/46] sh: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 40/46] sparc: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 41/46] tile: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 42/46] unicore32: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 43/46] xtensa: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 44/46] remoteproc: qcom: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 45/46] dma-mapping: Remove dma_get_attr Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 46/46] dma-mapping: Document the DMA attributes next to the declaration Krzysztof Kozlowski
2016-07-13 16:51 ` Bjorn Andersson [this message]
2016-07-13 10:37 ` [PATCH v6 17/46] infiniband: dma-mapping: Use unsigned long for dma_attrs Bart Van Assche
2016-07-13 10:47 ` Krzysztof Kozlowski
2016-07-13 10:56 ` Bart Van Assche
2016-07-13 11:03 ` Krzysztof Kozlowski
2016-07-13 11:14 ` [PATCH v6.1] " Krzysztof Kozlowski
2016-07-13 11:17 ` Krzysztof Kozlowski
2016-07-13 11:56 ` [PATCH v6.2] " Krzysztof Kozlowski
2016-07-13 12:29 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160713165131.GK23833@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=hch@infradead.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).