From: Fengguang Wu <fengguang.wu@intel.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: ming.lei@canonical.com, akpm@linux-foundation.org,
mmarek@suse.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, markivx@codeaurora.org,
stephen.boyd@linaro.org, zohar@linux.vnet.ibm.com,
broonie@kernel.org, tiwai@suse.de, johannes@sipsolutions.net,
chunkeey@googlemail.com, hauke@hauke-m.de,
jwboyer@fedoraproject.org, dmitry.torokhov@gmail.com,
dwmw2@infradead.org, jslaby@suse.com,
torvalds@linux-foundation.org, luto@amacapital.net,
rpurdie@rpsys.net, j.anaszewski@samsung.com,
Abhay_Salunke@dell.com, Julia.Lawall@lip6.fr,
Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, teg@jklm.no,
dhowells@redhat.com, martin.blumenstingl@googlemail.com,
nbd@nbd.name, mark.rutland@arm.com, robh+dt@kernel.org,
arend.vanspriel@broadcom.com, dev@kresin.me,
kvalo@codeaurora.org, Philip Li <philip.li@intel.com>
Subject: Re: [PATCH v2 0/5] firmware: add SmPL grammar to avoid issues
Date: Thu, 14 Jul 2016 11:35:05 +0800 [thread overview]
Message-ID: <20160714033505.GA26723@wfg-t540p.sh.intel.com> (raw)
In-Reply-To: <20160714030812.GT6239@wotan.suse.de>
On Thu, Jul 14, 2016 at 05:08:12AM +0200, Luis R. Rodriguez wrote:
>On Thu, Jul 14, 2016 at 10:23:36AM +0800, Fengguang Wu wrote:
>> On Thu, Jul 14, 2016 at 04:15:01AM +0200, Luis R. Rodriguez wrote:
>> >On Thu, Jul 14, 2016 at 07:52:07AM +0800, Fengguang Wu wrote:
>> >>Hi Luis,
>> >>
>> >>On Thu, Jul 07, 2016 at 02:56:44AM +0200, Luis R. Rodriguez wrote:
>> >>>On Thu, Jun 16, 2016 at 03:54:16PM -0700, Luis R. Rodriguez wrote:
>> >>>>The firmware API has had some issues a while ago, some of this is
>> >>>>not well documented, and its still hard to grasp. This documents
>> >>>>some of these issues, adds SmPL grammar rules to enable us to hunt
>> >>>>for issues, and annotations to help us with our effort to finally
>> >>>>compartamentalize that pesky usermode helper.
>> >>>>
>> >>>>Previously this was just one patch, the grammar rule to help
>> >>>>find request firmware API users on init or probe, this series
>> >>>>extends that effort with usermode helper grammar rules, and some
>> >>>>annotations and documentation on the firmware_class driver to
>> >>>>avoid further issues. Documenting the usermode helper and making
>> >>>>it clear why we cannot remove it is important for analysis for
>> >>>>the next series which adds the new flexible sysdata firmware API.
>> >>>>
>> >>>>This series depends on the coccicheck series which enables
>> >>>>annotations on coccinelle patches to require a specific
>> >>>>version of coccinelle [0], as such coordination with Michal is
>> >>>>in order.
>> >>>
>> >>>Michal is out until July 11, and upon further thought such coordination
>> >>>is not need, the annotation is in place as comments and as such
>> >>>merging this now won't have any negative effects other than the version
>> >>>check. Also the patches in question for the coccicheck change are all
>> >>>acked now and I expect them to be merged anyway.
>> >>>
>> >>>Which tree should firmware changes go through ?
>> >>
>> >>>>This series is also further extended next with the new sydata
>> >>>>API, the full set of changes is available on my linux-next tree [1].
>> >>>>
>> >>>>Perhaps now a good time to discuss -- if 0-day should enable the rule
>> >>>>scripts/coccinelle/api/request_firmware-usermode.cocci to be called on
>> >>>>every 0-day iteration, it runs rather fast and it should help police
>> >>>>against avoiding futher explicit users of the usermode helper.
>> >>>
>> >>>And if we are going to merge this anyone oppose enabling hunting
>> >>>for further explicit users of the usermode helper using grammar through
>> >>>0-day ?
>> >>
>> >>When *.cocci scripts lands upstream they'll be auto picked up by the
>> >>0-day bot to guard new patches/commits.
>> >
>> >Great thanks!
>> >
>> >>Are there further steps 0-day should do for request_firmware-upstream.cocci?
>> >
>> >It just requires coccinelle >= 1.0.5.
>>
>> That looks easy.
>
>Nice!
>
>> When do you estimate the script will land upstream?
>
>Well, this series has gone by a while now without any complaints, so
>I was poking to see if they can be merged now.
OK.
>> So we can make sure upgrade coccinelle before that time.
>
>There is another series which modernizes coccicheck [0] for which I just poked
>at as a well [1], one change which may be of importance to you is groks the
>Requires: tag on top of an SmPL patch, with that we simply just skip an SmPL
>patch if the version of coccinelle is older than the one specified, with that
>in place you can just upgrade when you want -- you'd just gain support for more
>SmPL patches when you do. Without that coccinelle would not work (fail) on the
>SmPL patch when tried. For this reason I originally had suggested perhaps
>this series should be carried by Michal.
>
>[0] https://lkml.kernel.org/r/1467238499-10889-1-git-send-email-mcgrof@kernel.org
>[1] https://lkml.kernel.org/r/20160713214539.GE6239@wotan.suse.de
It's glad to know these improvements. We'll watch their progress and
keep up in time. :)
Thanks,
Fengguang
next prev parent reply other threads:[~2016-07-14 3:35 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 22:54 [PATCH v2 0/5] firmware: add SmPL grammar to avoid issues Luis R. Rodriguez
2016-06-16 22:54 ` [PATCH v2 1/5] MAINTAINERS: extend firmware_class maintainer list Luis R. Rodriguez
2016-06-16 22:54 ` [PATCH v2 2/5] firmware: annotate thou shalt not request fw on init or probe Luis R. Rodriguez
2016-08-24 6:55 ` Daniel Vetter
2016-08-24 20:39 ` Luis R. Rodriguez
2016-08-25 11:05 ` Daniel Vetter
2016-08-25 19:41 ` Luis R. Rodriguez
2016-08-25 20:10 ` Daniel Vetter
2016-08-25 20:25 ` Luis R. Rodriguez
2016-08-25 20:30 ` Dmitry Torokhov
2016-09-02 23:59 ` Luis R. Rodriguez
2016-09-03 0:20 ` [RFC] fs: add userspace critical mounts event support Luis R. Rodriguez
2016-09-03 4:11 ` Linus Torvalds
2016-09-03 4:20 ` Dmitry Torokhov
[not found] ` <CA+55aFz4q5peXAeY9h8o3he7R=wXrBSYkOjMM9TehOw=pPoS+Q@mail.gmail.com>
2016-09-03 17:49 ` Dmitry Torokhov
2016-09-03 18:01 ` Linus Torvalds
2016-09-03 18:10 ` Dmitry Torokhov
2016-09-06 21:52 ` Luis R. Rodriguez
2016-09-06 22:28 ` Bjorn Andersson
2016-09-06 23:14 ` Luis R. Rodriguez
2016-09-24 1:37 ` Herbert, Marc
2016-09-24 17:41 ` Dmitry Torokhov
2016-10-05 0:00 ` Luis R. Rodriguez
2016-10-05 0:12 ` Linus Torvalds
2016-10-05 0:24 ` Luis R. Rodriguez
2016-10-05 0:32 ` Linus Torvalds
2016-10-05 17:38 ` Luis R. Rodriguez
2016-10-05 1:48 ` Josh Triplett
2016-10-05 1:58 ` Linus Torvalds
2016-09-06 17:46 ` Bjorn Andersson
2016-09-06 18:32 ` Linus Torvalds
2016-09-06 21:11 ` Bjorn Andersson
2016-09-06 21:50 ` Linus Torvalds
2016-09-06 23:04 ` Luis R. Rodriguez
2016-09-24 2:51 ` Herbert, Marc
2016-10-04 23:28 ` Luis R. Rodriguez
2016-09-06 22:32 ` Luis R. Rodriguez
2016-09-14 2:38 ` Rob Landley
2016-10-05 18:00 ` Luis R. Rodriguez
2016-10-05 18:08 ` Linus Torvalds
2016-10-05 19:46 ` Luis R. Rodriguez
2016-11-08 22:47 ` Luis R. Rodriguez
2016-11-09 9:13 ` Daniel Wagner
2016-11-09 23:40 ` Luis R. Rodriguez
2016-11-15 9:28 ` Johannes Berg
2016-06-16 22:54 ` [PATCH v2 3/5] firmware: update usermode helper docs and add SmPL report Luis R. Rodriguez
2016-06-16 22:54 ` [PATCH v2 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation Luis R. Rodriguez
2016-06-16 22:54 ` [PATCH v2 5/5] firmware: fix fw cache to avoid usermode helper on suspend Luis R. Rodriguez
2016-07-07 0:56 ` [PATCH v2 0/5] firmware: add SmPL grammar to avoid issues Luis R. Rodriguez
2016-07-13 21:47 ` Luis R. Rodriguez
2016-07-28 0:41 ` Luis R. Rodriguez
2016-08-03 14:50 ` Luis R. Rodriguez
2016-08-03 15:04 ` Greg KH
2016-08-03 17:06 ` Luis R. Rodriguez
2016-08-03 19:32 ` Greg KH
2016-08-03 19:46 ` Luis R. Rodriguez
2016-07-13 23:52 ` Fengguang Wu
2016-07-14 2:15 ` Luis R. Rodriguez
2016-07-14 2:23 ` Fengguang Wu
2016-07-14 3:08 ` Luis R. Rodriguez
2016-07-14 3:35 ` Fengguang Wu [this message]
2016-08-24 0:45 ` [PATCH v3 " mcgrof
2016-08-24 0:45 ` [PATCH v3 1/5] MAINTAINERS: extend firmware_class maintainer list mcgrof
2016-08-24 0:45 ` [PATCH v3 2/5] firmware: annotate thou shalt not request fw on init or probe mcgrof
2016-08-24 8:17 ` Gabriel Paubert
2016-09-02 18:26 ` Luis R. Rodriguez
2016-08-24 0:45 ` [PATCH v3 3/5] firmware: update usermode helper docs and add SmPL report mcgrof
2016-08-24 0:45 ` [PATCH v3 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation mcgrof
2016-08-24 0:45 ` [PATCH v3 5/5] firmware: fix fw cache to avoid usermode helper on suspend mcgrof
2016-08-31 7:03 ` Daniel Wagner
2016-09-02 18:13 ` Luis R. Rodriguez
2016-09-07 0:42 ` [PATCH v4 0/5] firmware: add SmPL grammar to avoid issues Luis R. Rodriguez
2016-09-07 0:42 ` [PATCH v4 1/5] MAINTAINERS: extend firmware_class maintainer list Luis R. Rodriguez
2016-09-07 6:43 ` Greg KH
2016-09-08 14:58 ` Luis R. Rodriguez
2016-09-08 15:25 ` Ming Lei
2016-09-07 0:42 ` [PATCH v4 2/5] firmware: annotate thou shalt not request fw on init or probe Luis R. Rodriguez
2016-09-07 0:42 ` [PATCH v4 3/5] firmware: update usermode helper docs and add SmPL report Luis R. Rodriguez
2016-09-07 0:42 ` [PATCH v4 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation Luis R. Rodriguez
2016-09-07 0:42 ` [PATCH v4 5/5] firmware: fix fw cache to avoid usermode helper on suspend Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714033505.GA26723@wfg-t540p.sh.intel.com \
--to=fengguang.wu@intel.com \
--cc=Abhay_Salunke@dell.com \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=akpm@linux-foundation.org \
--cc=arend.vanspriel@broadcom.com \
--cc=broonie@kernel.org \
--cc=chunkeey@googlemail.com \
--cc=dev@kresin.me \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hauke@hauke-m.de \
--cc=j.anaszewski@samsung.com \
--cc=johannes@sipsolutions.net \
--cc=jslaby@suse.com \
--cc=jwboyer@fedoraproject.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mark.rutland@arm.com \
--cc=markivx@codeaurora.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcgrof@kernel.org \
--cc=ming.lei@canonical.com \
--cc=mmarek@suse.com \
--cc=nbd@nbd.name \
--cc=nicolas.palix@imag.fr \
--cc=philip.li@intel.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=stephen.boyd@linaro.org \
--cc=teg@jklm.no \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).